Skip to content

Commit 64d2b3f

Browse files
committed
acceptance: stabilize start-single-node in tcl test
We've continued to see flakes on this test which contain messages of throttled stores on node startup. The hypothesis is that these are due to leftover data directories from prior startups during the same test. This change clears the `logs/db` data directory for those invocations and also adds the sql memory flag which the common tcl function also uses. Resolves cockroachdb#108405 Epic: None Release note: None
1 parent b91c919 commit 64d2b3f

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

pkg/cli/interactive_tests/test_missing_log_output.tcl

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,27 +63,30 @@ eexpect ":/# "
6363
stop_server $argv
6464

6565
start_test "Check that a server started with --logtostderr logs even info messages to stderr."
66-
send "$argv start-single-node -s=path=logs/db --insecure --logtostderr\r"
66+
send "$argv start-single-node --max-sql-memory=128MB -s=path=logs/db --insecure --logtostderr\r"
6767
eexpect "CockroachDB node starting"
6868
end_test
6969

7070
# Stop it.
7171
interrupt
7272
interrupt
7373
eexpect ":/# "
74+
system "rm -rf logs/db"
7475

7576
start_test "Check that --logtostderr can override the threshold but no error is printed on startup"
76-
send "echo marker; $argv start-single-node -s=path=logs/db --insecure --logtostderr=ERROR 2>&1 | grep -v '^\\*'\r"
77+
send "echo marker; $argv start-single-node --max-sql-memory=128MB -s=path=logs/db --insecure --logtostderr=ERROR 2>&1 | grep -v '^\\*'\r"
7778
eexpect "marker\r\nCockroachDB node starting"
7879
end_test
7980

8081
# Stop it.
8182
interrupt
8283
interrupt
8384
eexpect ":/# "
85+
system "rm -rf logs/db"
86+
8487

8588
start_test "Check that panic reports are printed to the log even when --logtostderr is specified"
86-
send "$argv start-single-node -s=path=logs/db --insecure --logtostderr\r"
89+
send "$argv start-single-node --max-sql-memory=128MB -s=path=logs/db --insecure --logtostderr\r"
8790
eexpect "CockroachDB node starting"
8891

8992
system "($argv sql --insecure -e \"select crdb_internal.force_panic('helloworld')\" || true)&"

0 commit comments

Comments
 (0)