Merge cockroachdb#107474 cockroachdb#107489 cockroachdb#107664 cockroachdb#107666 cockroachdb#107673 cockroachdb#107714 cockroachdb#107716

107474: cli/zip: emit SQL table data using TSV by default r=abarganier a=knz

Fixes cockroachdb#107473.
Epic: CRDB-28893

This is a partial revert of 35738d4.

It changes the default value of the `--format` flag back from JSON to TSV.

Release note (backward-incompatible change):
THIS RELEASE NOTE CANCELS THE CORRESPONDING PREVIOUS BACKWARD-INCOMPATIBLE CHANGE. New behavior, compatible with previous versions of CockroachDB: the command `cockroach debug zip` stores data retrieved from SQL tables in the remote cluster using the TSV format by default.

Release note (cli change): The default value of the `--format` parameter to `cockroach debug zip` is `tsv`, like other CLI commands that can extract SQL data.

107489: sql: Delete invalid TestDropColumnAfterMutations test r=rafiss a=rimadeodhar

This test checks the functionality for the following sequence of events:
1. A txn adds a constraint to a column on a table.
2. A separate txn drops the column.

However, this interaction between the two txns has been made explicit by the PR cockroachdb#92289. Since this PR, step (2) will fail if the constraint in step (1) is in the process of being added. As a result, the elaborate set up and sequence of events being tested in TestDropColumnAfterMutations is no longer necessary.

Release note: none
Epic: none
Fixes: cockroachdb#76843

107664: authors: add Angela Dietz to authors r=angeladietz a=angeladietz

Release note: None
Epic: None

107666: server: fix a race in tenant creation r=knz a=lidorcarmel

Previously, scanTenantsForRunnableServices() was not holding the mutex when SELECTing for the existing tenant names, which means that the following may happen:
- scanTenantsForRunnableServices() sees that only the system tenant exists
- createServerEntryLocked() then adds another tenant while holding the mutex
- scanTenantsForRunnableServices() takes the lock and stops the tenant that was just created because only the system tenant should be alive (which is wrong)

This patch changes scanTenantsForRunnableServices() to take the mutex before SELECTing for the existing tenants in order to avoid the race.

Epic: none
Fixes: cockroachdb#107434
Fixes: cockroachdb#107343
Fixes: cockroachdb#107154

Release note: None

107673: opt: remove Metadata.AllUserDefinedFunctions r=mgartner a=mgartner

The metadata method `AllUserDefinedFunctions` has been replaced with a
new function `HasUserDefinedFunctions` which provides a simpler API
without exposing the underlying UDF dependency map. The map is still
available outside of the opt package via the `TestingUDFDeps` method
which is designed for testing use only.

Epic: None

Release note: None


107714: roachtest: add warning to redacted github issue r=mgartner a=mgartner

Epic: None

Release note: None

107716: ui: extend search logic on insights page r=koorosh a=koorosh

This change extends the number of fields where
search is applied (instead of single transaction/
statement execution ID field).
It makes possible to search for any available ID
in Txn or statement insight.

Release note (ui change): search is performed on all ID fields of transaction and statement insights.

Resolves: cockroachdb#107253

Demo:

https://github.com/cockroachdb/cockroach/assets/3106437/7fb56720-3ab2-4be4-9500-457707f6f01d



Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: rimadeodhar <[email protected]>
Co-authored-by: Angela Dietz <[email protected]>
Co-authored-by: Lidor Carmel <[email protected]>
Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Andrii Vorobiov <[email protected]>

Author: 7 people

AUTHORS

@@ -73,7 +73,7 @@ Andy Kimball <[email protected]> <[email protected]> <32096062+andy-k
 Andy Woods <[email protected]> Andrew Woods <[email protected]>
 Andy Yang <[email protected]> <[email protected]> andyyang890 <[email protected]>
 Angela Chang <[email protected]> changangela <[email protected]> <[email protected]>
-Angela Dietz <[email protected]>
+Angela Dietz <[email protected]> <[email protected]>
 Angela Wen <[email protected]> angelapwen <[email protected]>
 Angela Xu <[email protected]> angelazxu <[email protected]>
 Anne Zhu <[email protected]>

pkg/cli/testdata/zip/partial1

@@ -1,6 +1,6 @@
 zip
 ----
-[cluster] retrieving SQL data for crdb_internal.cluster_database_privileges... writing output: debug/crdb_internal.cluster_database_privileges.json... done
-[cluster] retrieving SQL data for crdb_internal.table_indexes... writing output: debug/crdb_internal.table_indexes.json... done
-[cluster] retrieving SQL data for system.database_role_settings... writing output: debug/system.database_role_settings.json... done
-[cluster] retrieving SQL data for system.table_statistics... writing output: debug/system.table_statistics.json... done
+[cluster] retrieving SQL data for crdb_internal.cluster_database_privileges... writing output: debug/crdb_internal.cluster_database_privileges.txt... done
+[cluster] retrieving SQL data for crdb_internal.table_indexes... writing output: debug/crdb_internal.table_indexes.txt... done
+[cluster] retrieving SQL data for system.database_role_settings... writing output: debug/system.database_role_settings.txt... done
+[cluster] retrieving SQL data for system.table_statistics... writing output: debug/system.table_statistics.txt... done