Skip to content

Commit 8a69c35

Browse files
author
Zach Lite
committed
ui: fix infinite cluster setting refresh
The DatabaseTablePage was unconditionally refreshing cluster settings causing a flood of network requests. Epic: none Release note (bux fix): A bug has been fixed that caused a flood of requests to refresh cluster settings on the Table Detail page. If a user would like to see the effect of a modified cluster setting in DB Console, a page-reload is required.
1 parent 9355e10 commit 8a69c35

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

pkg/ui/workspaces/cluster-ui/src/databaseTablePage/databaseTablePage.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,9 @@ export class DatabaseTablePage extends React.Component<
246246

247247
componentDidMount(): void {
248248
this.refresh();
249+
if (this.props.refreshSettings != null) {
250+
this.props.refreshSettings();
251+
}
249252
}
250253

251254
componentDidUpdate(prevProp: Readonly<DatabaseTablePageProps>): void {
@@ -284,10 +287,6 @@ export class DatabaseTablePage extends React.Component<
284287
this.props.name,
285288
);
286289
}
287-
288-
if (this.props.refreshSettings != null) {
289-
this.props.refreshSettings();
290-
}
291290
}
292291

293292
private changeIndexSortSetting(sortSetting: SortSetting) {

0 commit comments

Comments
 (0)