Merge cockroachdb#108024

craig[bot] · mgartner · craig[bot] · commit 8fb2f86457e8 · 2023-08-03T13:37:33.000Z
108024: opt: remove unused OpName field of UniqueChecksItemPrivate r=mgartner a=mgartner

Epic: None

Release note: None

Co-authored-by: Marcus Gartner &lt;marcus@cockroachlabs.com&gt;
diff --git a/pkg/sql/opt/ops/mutation.opt b/pkg/sql/opt/ops/mutation.opt
@@ -292,7 +292,4 @@ define UniqueChecksItemPrivate {
     # KeyCols are the columns in the Check query that form the value tuple shown
     # in the error message.
     KeyCols ColList
-
-    # OpName is the name that should be used for this check in error messages.
-    OpName string
 }
diff --git a/pkg/sql/opt/optbuilder/mutation_builder_unique.go b/pkg/sql/opt/optbuilder/mutation_builder_unique.go
@@ -392,7 +392,6 @@ func (h *uniqueCheckHelper) buildInsertionCheck() memo.UniqueChecksItem {
 		Table:        h.mb.tabID,
 		CheckOrdinal: h.uniqueOrdinal,
 		KeyCols:      keyCols,
-		OpName:       h.mb.opName,
 	})
 }
 

Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,4 @@ define UniqueChecksItemPrivate {`
`292`	`292`	`# KeyCols are the columns in the Check query that form the value tuple shown`
`293`	`293`	`# in the error message.`
`294`	`294`	`KeyCols ColList`
`295`		`-`
`296`		`- # OpName is the name that should be used for this check in error messages.`
`297`		`- OpName string`
`298`	`295`	`}`
Original file line number	Diff line number	Diff line change
`@@ -392,7 +392,6 @@ func (h *uniqueCheckHelper) buildInsertionCheck() memo.UniqueChecksItem {`
`392`	`392`	`Table: h.mb.tabID,`
`393`	`393`	`CheckOrdinal: h.uniqueOrdinal,`
`394`	`394`	`KeyCols: keyCols,`
`395`		`- OpName: h.mb.opName,`
`396`	`395`	`})`
`397`	`396`	`}`
`398`	`397`