Skip to content

Commit 922d6e6

Browse files
committed
changefeedccl: warn on when using https sink urls
Fixes cockroachdb#98719. Release note: None
1 parent c917a6b commit 922d6e6

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

pkg/ccl/changefeedccl/changefeed_stmt.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -904,6 +904,15 @@ func validateSink(
904904
if err != nil {
905905
return err
906906
}
907+
u, err := url.Parse(details.SinkURI)
908+
if err != nil {
909+
return err
910+
}
911+
912+
if u.Scheme == changefeedbase.SinkSchemeCloudStorageHTTP || u.Scheme == changefeedbase.SinkSchemeCloudStorageHTTPS {
913+
p.BufferClientNotice(ctx, pgnotice.Newf(`%s sinks will emit using cloud storage semantics. For a webhook sink, prepend webhook- to the sink URI.`))
914+
}
915+
907916
var nilOracle timestampLowerBoundOracle
908917
canarySink, err := getAndDialSink(ctx, &p.ExecCfg().DistSQLSrv.ServerConfig, details,
909918
nilOracle, p.User(), jobID, sli)

0 commit comments

Comments
 (0)