sql: remove deferred c.bufferReadyForQuery

ecwall · ecwall · commit 94d156d4e5bc · 2023-08-01T06:44:56.000-04:00
Informs cockroachdb#105448 This line is only used in a testing knob, but is not required by any tests so it can be removed. Release note: None
diff --git a/pkg/sql/pgwire/conn.go b/pkg/sql/pgwire/conn.go
@@ -187,9 +187,6 @@ func (c *conn) processCommands(
 				_ = c.writeErr(ctx, retErr, &c.writerState.buf)
 				_ /* n */, _ /* err */ = c.writerState.buf.WriteTo(c.conn)
 				c.stmtBuf.Close()
-				// Send a ready for query to make sure the client can react.
-				// TODO(andrei, jordan): Why are we sending this exactly?
-				c.bufferReadyForQuery('I')
 			}
 		}
 		if !authOK {

Original file line number	Diff line number	Diff line change
`@@ -187,9 +187,6 @@ func (c *conn) processCommands(`
`187`	`187`	`_ = c.writeErr(ctx, retErr, &c.writerState.buf)`
`188`	`188`	`_ /* n /, _ / err */ = c.writerState.buf.WriteTo(c.conn)`
`189`	`189`	`c.stmtBuf.Close()`
`190`		`- // Send a ready for query to make sure the client can react.`
`191`		`- // TODO(andrei, jordan): Why are we sending this exactly?`
`192`		`- c.bufferReadyForQuery('I')`
`193`	`190`	`}`
`194`	`191`	`}`
`195`	`192`	`if !authOK {`