sql: add pg error codes to udf logic tests

Used postgres where possible to generate the error codes. A few
questionable codes have been marked with TODOs to be addressed in future
work.

Epic: none
Informs: cockroachdb#107369

Release note: none

Author: rharding6373

pkg/sql/logictest/testdata/logic_test/udf

@@ -18,10 +18,10 @@ CREATE TYPE notmyworkday AS ENUM ('Monday', 'Tuesday');
 
 subtest usage
 
-statement error pq: no language specified
+statement error pgcode 42P13 pq: no language specified
 CREATE FUNCTION f() RETURNS INT IMMUTABLE AS $$ SELECT 1 $$;
 
-statement error pq: no function body specified
+statement error pgcode 42P13 pq: no function body specified
 CREATE FUNCTION f() RETURNS INT IMMUTABLE LANGUAGE SQL;
 
 
@@ -34,7 +34,7 @@ CREATE FUNCTION b(i INT) RETURNS INT LANGUAGE SQL AS 'SELECT a FROM ab WHERE a =
 statement ok
 CREATE FUNCTION c(i INT, j INT) RETURNS INT LANGUAGE SQL AS 'SELECT i - j'
 
-statement error column \"j\" does not exist
+statement error pgcode 42703 column \"j\" does not exist
 CREATE FUNCTION err(i INT) RETURNS INT LANGUAGE SQL AS 'SELECT j'
 
 statement error pgcode 42703 column \"j\" does not exist
@@ -46,13 +46,13 @@ CREATE FUNCTION err() RETURNS INT LANGUAGE SQL AS 'SELECT a FROM dne'
 statement ok
 CREATE FUNCTION d(i INT2) RETURNS INT4 LANGUAGE SQL AS 'SELECT i'
 
-statement error return type mismatch in function declared to return bool\nDETAIL: Actual return type is int
+statement error pgcode 42P13 return type mismatch in function declared to return bool\nDETAIL: Actual return type is int
 CREATE FUNCTION err(i INT, j INT) RETURNS BOOL LANGUAGE SQL AS 'SELECT i - j'
 
-statement error return type mismatch in function declared to return int\nDETAIL: Actual return type is bool
+statement error pgcode 42P13 return type mismatch in function declared to return int\nDETAIL: Actual return type is bool
 CREATE FUNCTION err(b BOOL) RETURNS INT LANGUAGE SQL AS 'SELECT b'
 
-statement error return type mismatch in function declared to return bool\nDETAIL: Actual return type is int
+statement error pgcode 42P13 return type mismatch in function declared to return bool\nDETAIL: Actual return type is int
 CREATE FUNCTION err(i INT, j INT) RETURNS BOOL LANGUAGE SQL AS 'SELECT i - j'
 
 # TODO(#100962): Add support for default parameters.
@@ -64,7 +64,7 @@ CREATE FUNCTION err(i INT, j INT DEFAULT 2) RETURNS INT LANGUAGE SQL AS 'SELECT
 statement ok
 CREATE TABLE t_implicit_type(a INT PRIMARY KEY, b STRING);
 
-statement error pq: return type mismatch in function declared to return int\nDETAIL: Actual return type is record
+statement error pgcode 42P13 pq: return type mismatch in function declared to return int\nDETAIL: Actual return type is record
 CREATE FUNCTION f() RETURNS INT IMMUTABLE LANGUAGE SQL AS $$ SELECT a, b from t_implicit_type $$
 
 # Create function with no references.
@@ -120,7 +120,7 @@ CREATE FUNCTION public.f(IN a test.public.notmyworkday)
   SELECT nextval('public.sq1'::REGCLASS);
 $$
 
-statement error pq: unimplemented: alter function depends on extension not supported.*
+statement error pgcode 0A000 pq: unimplemented: alter function depends on extension not supported.*
 ALTER FUNCTION f() DEPENDS ON EXTENSION postgis
 
 subtest end
@@ -277,7 +277,7 @@ CREATE FUNCTION public.proc_f(IN STRING, IN b INT8)
   SELECT 'hello';
 $$
 
-statement error pq: unknown function: proc_f_2()
+statement error pgcode 42883 pq: unknown function: proc_f_2()
 SHOW CREATE FUNCTION proc_f_2;
 
 query T
@@ -330,10 +330,10 @@ SELECT 'sc.proc_f_2'::REGPROC::INT;
 ----
 100121
 
-statement error pq: unknown function: no_such_func()
+statement error pgcode 42883 pq: unknown function: no_such_func()
 SELECT 'no_such_func'::REGPROC;
 
-statement error pq: more than one function named 'proc_f'
+statement error pgcode 42P09 pq: more than one function named 'proc_f'
 SELECT 'proc_f'::REGPROC;
 
 query T
@@ -406,17 +406,18 @@ CREATE FUNCTION sc1.f_test_drop(IN INT8)
   SELECT 1;
 $$
 
-statement error pq: function name \"f_test_drop\" is not unique
+# TODO(107369): Postgres errors with code 42725 here.
+statement error pgcode XXUUU pq: function name \"f_test_drop\" is not unique
 DROP FUNCTION f_test_drop;
 
 statement ok
 DROP FUNCTION IF EXISTS f_not_existing;
 
-statement error pq: unknown function: f_not_existing\(\): function undefined
+statement error pgcode 42883 pq: unknown function: f_not_existing\(\): function undefined
 DROP FUNCTION f_not_existing;
 
 # drop a function twice should fail.
-statement error pq: function f_test_drop\(\) does not exist: function undefined
+statement error pgcode 42883 pq: function f_test_drop\(\) does not exist: function undefined
 BEGIN;
 DROP FUNCTION f_test_drop();
 DROP FUNCTION f_test_drop();
@@ -459,7 +460,7 @@ $$
 statement ok
 DROP FUNCTION f_test_drop(INT), f_test_drop(INT);
 
-statement error pq: unknown function: public.f_test_drop\(\): function undefined
+statement error pgcode 42883 pq: unknown function: public.f_test_drop\(\): function undefined
 SELECT create_statement FROM [SHOW CREATE FUNCTION public.f_test_drop];
 
 query T
@@ -478,7 +479,7 @@ $$
 statement ok
 DROP FUNCTION f_test_drop(INT);
 
-statement error pq: unknown function: sc1.f_test_drop\(\): function undefined
+statement error pgcode 42883 pq: unknown function: sc1.f_test_drop\(\): function undefined
 SELECT create_statement FROM [SHOW CREATE FUNCTION sc1.f_test_drop];
 
 # If there are identical function signatures in different schemas, multiple drop
@@ -519,10 +520,10 @@ DROP FUNCTION f_test_drop();
 DROP FUNCTION f_test_drop();
 COMMIT;
 
-statement error pq: unknown function: public.f_test_drop\(\): function undefined
+statement error pgcode 42883 pq: unknown function: public.f_test_drop\(\): function undefined
 SELECT create_statement FROM [SHOW CREATE FUNCTION public.f_test_drop];
 
-statement error pq: unknown function: sc1.f_test_drop\(\): function undefined
+statement error pgcode 42883 pq: unknown function: sc1.f_test_drop\(\): function undefined
 SELECT create_statement FROM [SHOW CREATE FUNCTION sc1.f_test_drop];
 
 statement ok
@@ -547,30 +548,30 @@ SELECT f_test_exec_dropped(123);
 statement ok
 DROP FUNCTION f_test_exec_dropped;
 
-statement error pq: unknown function: f_test_exec_dropped\(\): function undefined
+statement error pgcode 42883 pq: unknown function: f_test_exec_dropped\(\): function undefined
 SELECT f_test_exec_dropped(321);
 
 subtest end
 
 
 subtest create_or_replace_function
 
-statement error pq: parameter name "a" used more than once
+statement error pgcode 42P13 pq: parameter name "a" used more than once
 CREATE FUNCTION f_test_cor(a INT, a INT) RETURNS INT IMMUTABLE LANGUAGE SQL AS $$ SELECT 1 $$;
 
 statement ok
 CREATE FUNCTION f_test_cor(a INT, b INT) RETURNS INT IMMUTABLE LEAKPROOF STRICT LANGUAGE SQL AS $$ SELECT 1 $$;
 
-statement error pq: function "f_test_cor" already exists with same argument types
+statement error pgcode 42723 pq: function "f_test_cor" already exists with same argument types
 CREATE FUNCTION f_test_cor(a INT, b INT) RETURNS INT IMMUTABLE LANGUAGE SQL AS $$ SELECT 1 $$;
 
 statement ok
 CREATE OR REPLACE FUNCTION f_test_cor_not_exist(a INT, b INT) RETURNS INT IMMUTABLE LANGUAGE SQL AS $$ SELECT 1 $$;
 
-statement error pq: cannot change name of input parameter "b"
+statement error pgcode 42P13 pq: cannot change name of input parameter "b"
 CREATE OR REPLACE FUNCTION f_test_cor(a INT, c INT) RETURNS INT IMMUTABLE LANGUAGE SQL AS $$ SELECT 1 $$;
 
-statement error pq: cannot change return type of existing function
+statement error pgcode 42P13 pq: cannot change return type of existing function
 CREATE OR REPLACE FUNCTION f_test_cor(a INT, b INT) RETURNS STRING IMMUTABLE LANGUAGE SQL AS $$ SELECT 'hello' $$;
 
 statement error pgcode 42P13 leak proof function must be immutable, but got volatility: VOLATILE
@@ -632,7 +633,7 @@ statement ok
 CREATE SCHEMA sc_seq_qualified_name;
 CREATE SEQUENCE sc_seq_qualified_name.sq;
 
-statement error pq: relation "sc_seq_qualified_name.sq" does not exist
+statement error pgcode 42P01 pq: relation "sc_seq_qualified_name.sq" does not exist
 CREATE FUNCTION f_seq_qualified_name() RETURNS INT LANGUAGE SQL AS $$ SELECT * FROM nextval('"sc_seq_qualified_name.sq"') $$;
 
 statement ok
@@ -835,18 +836,18 @@ subtest end
 
 subtest args
 
-statement error pq: SQL functions cannot have arguments of type record
+statement error pgcode 42P13 pq: SQL functions cannot have arguments of type record
 CREATE FUNCTION f(r RECORD) RETURNS INT LANGUAGE SQL AS 'SELECT i'
 
 # TODO(mgartner): Technically $3 is a parameter, and the error message should be
 # more similar to Postgres's "there is no parameter $3".
-statement error no value provided for placeholder: \$3
+statement error pgcode 42P02 no value provided for placeholder: \$3
 CREATE FUNCTION err(x INT, y INT) RETURNS INT LANGUAGE SQL AS 'SELECT x + y + $1 + $2 + $3'
 
-statement error no value provided for placeholder: \$3
+statement error pgcode 42P02 no value provided for placeholder: \$3
 CREATE FUNCTION err(INT, INT) RETURNS INT LANGUAGE SQL AS 'SELECT $1 + $2 + $3'
 
-statement error placeholder index must be between 1 and 65536
+statement error pgcode 42601 placeholder index must be between 1 and 65536
 CREATE FUNCTION err(INT) RETURNS INT LANGUAGE SQL AS 'SELECT 1 + $0'
 
 statement ok
@@ -1014,7 +1015,7 @@ SELECT single_quote('hello')
 ----
 'hello'
 
-statement error unterminated string
+statement error pgcode 42601 unterminated string
 CREATE FUNCTION err() RETURNS STRING LANGUAGE SQL AS $outer$
   SELECT $inner$hello$outer$
 $inner$

pkg/sql/logictest/testdata/logic_test/udf_delete

@@ -12,7 +12,7 @@ INSERT INTO kv VALUES (1, 2), (3, 4), (5, 6), (7, 8)
 statement ok
 CREATE VIEW kview AS SELECT k,v FROM kv
 
-statement error pq: "test.public.kview" is not a table
+statement error pgcode 42809 pq: "test.public.kview" is not a table
 CREATE FUNCTION f_view() RETURNS RECORD AS
 $$
   DELETE FROM kview;

pkg/sql/logictest/testdata/logic_test/udf_in_column_defaults

@@ -355,7 +355,7 @@ CREATE TABLE t2(
   FAMILY fam_0 (a, b)
 );
 
-statement error cannot drop function "f1" because other objects \(\[test.public.t1, test.public.t2\]\) still depend on it
+statement error pgcode 2BP01 cannot drop function "f1" because other objects \(\[test.public.t1, test.public.t2\]\) still depend on it
 DROP FUNCTION f1;
 
 statement ok
@@ -508,5 +508,5 @@ statement ok
 CREATE TABLE t_circle(a INT PRIMARY KEY, b INT);
 CREATE FUNCTION f_circle() RETURNS INT LANGUAGE SQL AS $$ SELECT a FROM t_circle $$;
 
-statement error pq: cannot add dependency from descriptor \d+ to function f_circle \(\d+\) because there will be a dependency cycle
+statement error pgcode XXUUU pq: cannot add dependency from descriptor \d+ to function f_circle \(\d+\) because there will be a dependency cycle
 ALTER TABLE t_circle ALTER COLUMN b SET DEFAULT f_circle();

pkg/sql/logictest/testdata/logic_test/udf_in_constraints

@@ -229,7 +229,7 @@ CREATE TABLE t2(
   FAMILY fam_0 (a, b)
 );
 
-statement error cannot drop function "f1" because other objects \(\[test.public.t1, test.public.t2\]\) still depend on it
+statement error pgcode 2BP01 cannot drop function "f1" because other objects \(\[test.public.t1, test.public.t2\]\) still depend on it
 DROP FUNCTION f1;
 
 statement ok
@@ -368,26 +368,26 @@ CREATE TABLE t1 (
   FAMILY fam_0 (a, b)
 );
 
-statement error failed to satisfy CHECK constraint \(public\.f1\(b\) > 1:::INT8\)
+statement error pgcode 23514 failed to satisfy CHECK constraint \(public\.f1\(b\) > 1:::INT8\)
 INSERT INTO t1 VALUES (1,0);
 
 statement ok
 INSERT INTO t1 VALUES (1,1);
 
-statement error validation of CHECK "public\.f1\(a\) > 10:::INT8" failed on row: a=1, b=1
+statement error pgcode 23514 validation of CHECK "public\.f1\(a\) > 10:::INT8" failed on row: a=1, b=1
 ALTER TABLE t1 ADD CONSTRAINT cka CHECK (f1(a) > 10);
 
 # Make sure that constraint still works after a function is renamed.
 statement ok
 ALTER TABLE t1 ADD CONSTRAINT cka CHECK (f1(a) > 1);
 
-statement error pq: failed to satisfy CHECK constraint \(public\.f1\(b\) > 1:::INT8\)
+statement error pgcode 23514 pq: failed to satisfy CHECK constraint \(public\.f1\(b\) > 1:::INT8\)
 INSERT INTO t1 VALUES (2, -1);
 
 statement ok
 ALTER FUNCTION f1 RENAME to f2;
 
-statement error pq: failed to satisfy CHECK constraint \(public\.f2\(b\) > 1:::INT8\)
+statement error pgcode 23514 pq: failed to satisfy CHECK constraint \(public\.f2\(b\) > 1:::INT8\)
 INSERT INTO t1 VALUES (2, -1);
 
 query T
@@ -433,5 +433,6 @@ statement ok
 CREATE TABLE t_circle(a INT PRIMARY KEY, b INT);
 CREATE FUNCTION f_circle() RETURNS INT LANGUAGE SQL AS $$ SELECT a FROM t_circle $$;
 
+# TODO(107369): This does not appear to error in postgres.
 statement error .*cannot add dependency from descriptor \d+ to function f_circle \(\d+\) because there will be a dependency cycle
 ALTER TABLE t_circle ADD CONSTRAINT ckb CHECK (b + f_circle() > 1);

pkg/sql/logictest/testdata/logic_test/udf_insert

@@ -1,7 +1,7 @@
 statement ok
 CREATE TABLE t (a INT PRIMARY KEY, b INT DEFAULT 0);
 
-statement error pq: return type mismatch in function declared to return record\nDETAIL: Function's final statement must be SELECT or INSERT/UPDATE/DELETE RETURNING.
+statement error pgcode 42P13 pq: return type mismatch in function declared to return record\nDETAIL: Function's final statement must be SELECT or INSERT/UPDATE/DELETE RETURNING.
 CREATE FUNCTION f_err() RETURNS RECORD AS
 $$
   INSERT INTO t VALUES (1,2);
@@ -18,20 +18,22 @@ SELECT f_void();
 ----
 NULL
 
-statement error missing "a" primary key column
+# TODO(107369): This doesn't error in postgres, and this is the error code for
+# invalid foreign key, which may not make sense.
+statement error pgcode 42830 missing "a" primary key column
 CREATE FUNCTION f_err(b INT) RETURNS RECORD AS
 $$
   INSERT INTO t (b) VALUES (b);
   SELECT * FROM t WHERE t.a=a AND t.b=b;
 $$ LANGUAGE SQL;
 
-statement error pq: volatile statement not allowed in stable function
+statement error pgcode 22023 pq: volatile statement not allowed in stable function
 CREATE FUNCTION f_err(i INT, j INT) RETURNS RECORD STABLE AS
 $$
   INSERT INTO t VALUES (i,j) RETURNING *;
 $$ LANGUAGE SQL;
 
-statement error pq: volatile statement not allowed in immutable function
+statement error pgcode 22023 pq: volatile statement not allowed in immutable function
 CREATE FUNCTION f_err(i INT, j INT) RETURNS RECORD IMMUTABLE AS
 $$
   INSERT INTO t VALUES (i,j) RETURNING *;
@@ -54,7 +56,7 @@ SELECT f_insert(3,4);
 ----
 (3,4)
 
-statement error duplicate key
+statement error pgcode 23505 duplicate key
 SELECT f_insert(3,4);
 
 query II rowsort
@@ -138,7 +140,7 @@ SELECT f_2values(7,8,9,10);
 (7,8)
 (9,10)
 
-statement error pq: duplicate key value violates unique constraint "t_multi_pkey"
+statement error pgcode 23505 pq: duplicate key value violates unique constraint "t_multi_pkey"
 SELECT f_2values(42,42,42,42);
 
 statement ok
@@ -155,7 +157,7 @@ SELECT f_2inserts(11,12,13,14);
 (11,12)
 (13,14)
 
-statement error pq: duplicate key value violates unique constraint "t_multi_pkey"
+statement error pgcode 23505 pq: duplicate key value violates unique constraint "t_multi_pkey"
 SELECT f_2inserts(42,42,42,42);
 
 # None of the duplicate key inserts should have succeeded.
@@ -260,7 +262,7 @@ $$
   INSERT INTO t_checkb VALUES (1, 0) ON CONFLICT(a) DO UPDATE SET b=0 RETURNING *;
 $$ LANGUAGE SQL;
 
-statement error pq: failed to satisfy CHECK constraint \(b > 1:::INT8\)
+statement error pgcode 23514 pq: failed to satisfy CHECK constraint \(b > 1:::INT8\)
 SELECT f_checkb();
 
 subtest end

pkg/sql/logictest/testdata/logic_test/udf_oid_ref

@@ -32,7 +32,7 @@ SELECT * FROM t1@idx WHERE [FUNCTION 1074](b, ',') = ARRAY['hello','new','world'
 statement ok
 ALTER TABLE t1 ADD CONSTRAINT c_len CHECK ([FUNCTION 814](b) > 2)
 
-statement error pq: failed to satisfy CHECK constraint \(length\(b\) > 2:::INT8\)
+statement error pgcode 23514 pq: failed to satisfy CHECK constraint \(length\(b\) > 2:::INT8\)
 INSERT INTO t1 VALUES (3, 'a')
 
 statement ok
@@ -59,7 +59,7 @@ hello world
 
 # Make sure that argument types are still checked even we know which function
 # overload to use.
-statement error pq: unknown signature: public.f2\(int\)
+statement error pgcode 42883 pq: unknown signature: public.f2\(int\)
 SELECT [FUNCTION $fn_oid](123)
 
 # Make sure that renaming does not break the reference.
@@ -86,7 +86,7 @@ hello world
 statement ok
 DROP FUNCTION sc1.f2_new(STRING);
 
-statement error function undefined
+statement error pgcode 42883 function undefined
 SELECT [FUNCTION $fn_oid]('maybe')
 
 # Referencing UDF OID within a UDF
@@ -98,7 +98,7 @@ let $fn_oid
 SELECT oid FROM pg_catalog.pg_proc WHERE proname = 'f_in_udf'
 
 # TODO(chengxiong,mgartner): Fix this test when we enable support of calling UDFs from UDFs.
-statement error pq: function \d+ not found: function undefined
+statement error pgcode 42883 pq: function \d+ not found: function undefined
 CREATE FUNCTION f_using_udf() RETURNS INT LANGUAGE SQL AS $$ SELECT [FUNCTION $fn_oid]() $$;
 
 # 814 is the OID of builtin function "length" with signature, and it's ok to