Skip to content

Commit c56dcaa

Browse files
committed
schemachanger: Cleanup redundant tests and refactor it
This commit recognizes that there were previously three redundant tests about concurrent schema changer behavior so it deletes them and rewrite it to a simpler one. Release note: None
1 parent 1fd3eb8 commit c56dcaa

File tree

2 files changed

+121
-775
lines changed

2 files changed

+121
-775
lines changed

pkg/sql/schemachanger/BUILD.bazel

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,39 +39,34 @@ go_test(
3939
"//pkg/ccl",
4040
"//pkg/jobs",
4141
"//pkg/jobs/jobspb",
42+
"//pkg/keys",
43+
"//pkg/kv",
4244
"//pkg/roachpb",
4345
"//pkg/security/securityassets",
4446
"//pkg/security/securitytest",
4547
"//pkg/server",
4648
"//pkg/sql",
4749
"//pkg/sql/catalog",
48-
"//pkg/sql/catalog/descpb",
4950
"//pkg/sql/catalog/desctestutils",
5051
"//pkg/sql/execinfra",
51-
"//pkg/sql/pgwire/pgcode",
5252
"//pkg/sql/rowenc",
5353
"//pkg/sql/schemachanger/scexec",
5454
"//pkg/sql/schemachanger/scop",
5555
"//pkg/sql/schemachanger/scplan",
5656
"//pkg/sql/schemachanger/sctest", # keep
57-
"//pkg/sql/sqltestutils",
57+
"//pkg/sql/sessiondatapb",
5858
"//pkg/testutils",
5959
"//pkg/testutils/serverutils",
6060
"//pkg/testutils/sqlutils",
61-
"//pkg/util",
6261
"//pkg/util/ctxgroup",
6362
"//pkg/util/leaktest",
6463
"//pkg/util/log",
6564
"//pkg/util/protoutil",
6665
"//pkg/util/randutil",
67-
"//pkg/util/syncutil",
68-
"@com_github_cockroachdb_cockroach_go_v2//crdb",
6966
"@com_github_cockroachdb_errors//:errors",
7067
"@com_github_cockroachdb_errors//errorspb",
71-
"@com_github_lib_pq//:pq",
7268
"@com_github_stretchr_testify//assert",
7369
"@com_github_stretchr_testify//require",
74-
"@org_golang_x_sync//errgroup",
7570
],
7671
)
7772

0 commit comments

Comments
 (0)