roachprod-microbench: fix delta string parsing

herkolategan · herkolategan · commit c9eed3ecd326 · 2023-07-24T11:37:54.000+01:00
A microbenchmark run, ran into an unexpected value for the delta string produced
by the perf package. This change adds the "?" case so that all other values can
be parsed correctly.

Release note: None
Epic: None
diff --git a/pkg/cmd/roachprod-microbench/google/service.go b/pkg/cmd/roachprod-microbench/google/service.go
@@ -212,7 +212,7 @@ func (srv *Service) createRawSheet(
 			vals = append(vals, numCell(entry.Summaries[run].Center))
 		}
 		delta := comparison.FormattedDelta
-		if delta == "~" {
+		if delta == "~" || delta == "?" {
 			vals = append(vals, strCell(delta))
 		} else {
 			vals = append(vals, percentCell(deltaToNum(delta)))

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ func (srv *Service) createRawSheet(`
`212`	`212`	`vals = append(vals, numCell(entry.Summaries[run].Center))`
`213`	`213`	`}`
`214`	`214`	`delta := comparison.FormattedDelta`
`215`		`- if delta == "~" {`
	`215`	`+ if delta == "~" \|\| delta == "?" {`
`216`	`216`	`vals = append(vals, strCell(delta))`
`217`	`217`	`} else {`
`218`	`218`	`vals = append(vals, percentCell(deltaToNum(delta)))`