sctest: loop var capture fix

herkolategan · herkolategan · commit e0623206010b · 2023-08-08T16:57:21.000+01:00
`tc` variable will be captured by reference in a loop and used by a parallel
test, resulting in only the last case being tested. This change captures `tc`.

Release note: None
Epic: None
diff --git a/pkg/sql/schemachanger/sctest/framework.go b/pkg/sql/schemachanger/sctest/framework.go
@@ -712,6 +712,7 @@ func cumulativeTestForEachPostCommitStage(
 			}
 			var hasFailed bool
 			for _, tc := range testCases {
+				tc := tc // capture loop variable
 				fn := func(t *testing.T) {
 					t.Parallel() // SAFE FOR TESTING
 					tf(t, tc)

Original file line number	Diff line number	Diff line change
`@@ -712,6 +712,7 @@ func cumulativeTestForEachPostCommitStage(`
`712`	`712`	`}`
`713`	`713`	`var hasFailed bool`
`714`	`714`	`for _, tc := range testCases {`
	`715`	`+ tc := tc // capture loop variable`
`715`	`716`	`fn := func(t *testing.T) {`
`716`	`717`	`t.Parallel() // SAFE FOR TESTING`
`717`	`718`	`tf(t, tc)`