Skip to content

Commit e9add29

Browse files
craig[bot]kvoli
andcommitted
107900: roachtest: output error and bump vmodule on lease preferences test r=erikgrinaker a=kvoli The `lease-preferences` roachtest did not log the state of preference conformance on timeout. This commit updates the error check, hit on timeout, to show the result. Also bump the vmodule settings to show lease acquisitions and lease preference errors. Epic: none Informs: cockroachdb#107862 Release note: None Co-authored-by: Austen McClernon <[email protected]>
2 parents 5c54cd9 + b11af97 commit e9add29

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pkg/cmd/roachtest/tests/lease_preferences.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,8 @@ func runLeasePreferences(
188188
// dc=2: n3 n4
189189
// ...
190190
// dc=N: n2N-1 n2N
191-
fmt.Sprintf("--locality=region=fake-region,zone=fake-zone,dc=%d", (node-1)/2+1))
191+
fmt.Sprintf("--locality=region=fake-region,zone=fake-zone,dc=%d", (node-1)/2+1),
192+
"--vmodule=replica_proposal=2,replicate_queue=3,replicate=3")
192193
c.Start(ctx, t.L(), opts, settings, c.Node(node))
193194

194195
}
@@ -223,7 +224,7 @@ func runLeasePreferences(
223224
checkLeasePreferenceConformance := func(ctx context.Context) {
224225
result, err := waitForLeasePreferences(
225226
ctx, t, c, spec.checkNodes, spec.waitForLessPreferred, stableDuration)
226-
require.NoError(t, err)
227+
require.NoError(t, err, result)
227228
require.Truef(t, !result.violating(), "violating lease preferences %s", result)
228229
if spec.waitForLessPreferred {
229230
require.Truef(t, !result.lessPreferred(), "less preferred preferences %s", result)

0 commit comments

Comments
 (0)