schemafeed: improve some tests

Release note: None

Author: knz

pkg/ccl/changefeedccl/schemafeed/BUILD.bazel

@@ -72,7 +72,6 @@ go_test(
         "//pkg/sql/catalog",
         "//pkg/sql/catalog/descpb",
         "//pkg/sql/catalog/tabledesc",
-        "//pkg/sql/pgwire",
         "//pkg/testutils",
         "//pkg/testutils/datapathutils",
         "//pkg/testutils/serverutils",

pkg/ccl/changefeedccl/schemafeed/schema_feed_test.go

@@ -24,7 +24,6 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/descpb"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/tabledesc"
-	"github.com/cockroachdb/cockroach/pkg/sql/pgwire"
 	"github.com/cockroachdb/cockroach/pkg/testutils"
 	"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
 	"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
@@ -197,7 +196,7 @@ func TestFetchDescriptorVersionsCPULimiterPagination(t *testing.T) {
 	ctx := context.Background()
 	var numRequests int
 	first := true
-	s, db, _ := serverutils.StartServer(t, base.TestServerArgs{
+	srv, db, _ := serverutils.StartServer(t, base.TestServerArgs{
 		Knobs: base.TestingKnobs{Store: &kvserver.StoreTestingKnobs{
 			TestingRequestFilter: func(ctx context.Context, request *kvpb.BatchRequest) *kvpb.Error {
 				for _, ru := range request.Requests {
@@ -220,11 +219,9 @@ func TestFetchDescriptorVersionsCPULimiterPagination(t *testing.T) {
 			},
 		}},
 	})
-	defer s.Stopper().Stop(ctx)
+	defer srv.Stopper().Stop(ctx)
+	s := srv.ApplicationLayer()
 	sqlServer := s.SQLServer().(*sql.Server)
-	if len(s.TestTenants()) != 0 {
-		sqlServer = s.TestTenants()[0].PGServer().(*pgwire.Server).SQLServer
-	}
 
 	sqlDB := sqlutils.MakeSQLRunner(db)
 	beforeCreate := hlc.Timestamp{WallTime: timeutil.Now().UnixNano()}

pkg/ccl/changefeedccl/schemafeed/table_event_filter_datadriven_test.go

@@ -64,12 +64,11 @@ func TestDataDriven(t *testing.T) {
 	testData := datapathutils.TestDataPath(t, "")
 	datadriven.Walk(t, testData, func(t *testing.T, path string) {
 		ctx := context.Background()
-		ts, sqlDB, _ := serverutils.StartServer(t, base.TestServerArgs{
-			// TODO(ajwerner): Otherwise the test gets skipped due to some CCL warning.
-			DefaultTestTenant: base.TODOTestTenantDisabled,
-		})
+		srv, sqlDB, _ := serverutils.StartServer(t, base.TestServerArgs{})
+		defer srv.Stopper().Stop(ctx)
+		ts := srv.ApplicationLayer()
+
 		tdb := sqlutils.MakeSQLRunner(sqlDB)
-		defer ts.Stopper().Stop(ctx)
 		ctx, cancel := ts.Stopper().WithCancelOnQuiesce(ctx)
 		defer cancel()
 		schemaFeeds := map[int]schemafeed.SchemaFeed{}

pkg/testutils/lint/lint_test.go

@@ -2230,7 +2230,6 @@ func TestLint(t *testing.T) {
 			":!ccl/changefeedccl/helpers_test.go",
 			":!ccl/changefeedccl/parquet_test.go",
 			":!ccl/changefeedccl/scheduled_changefeed_test.go",
-			":!ccl/changefeedccl/schemafeed/table_event_filter_datadriven_test.go",
 			":!ccl/importerccl/ccl_test.go",
 			":!ccl/kvccl/kvfollowerreadsccl/boundedstaleness_test.go",
 			":!ccl/kvccl/kvfollowerreadsccl/followerreads_test.go",