Skip to content

Commit f3b8cf6

Browse files
committed
kvserver: avoid running intensive decommission test under deadlock
The kvserver test `TestDecommission`, which runs a 5-node cluster and decommissions 4 of those 5 nodes, has trouble completing fast enough when under a race or deadlock configuration. While race configurations were already skipped, this modifies the test to be skipped under deadlock configurations as well. Fixes: cockroachdb#106096 Release note: None
1 parent 6f42039 commit f3b8cf6

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

pkg/kv/kvserver/client_decommission_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ func TestDecommission(t *testing.T) {
3434
defer leaktest.AfterTest(t)()
3535
defer log.Scope(t).Close(t)
3636

37-
// Five nodes is too much to reliably run under testrace with our aggressive
38-
// liveness timings.
39-
skip.UnderRace(t, "#39807 and #37811")
37+
// Five nodes is too much to reliably run under race/deadlock with our
38+
// aggressive liveness timings.
39+
skip.UnderRaceWithIssue(t, 39807, "#39807 and #37811")
40+
skip.UnderDeadlockWithIssue(t, 39807, "#39807 and #37811")
4041

4142
ctx := context.Background()
4243
tc := testcluster.StartTestCluster(t, 5, base.TestClusterArgs{

0 commit comments

Comments
 (0)