Fix rc.d script to properly load configuration and start on boot

Previous: The rc.d/spkrd service script had rcorder comments at the
top of the file but was not functioning correctly during boot. The
load_rc_config call appeared after command_args was defined, which
meant any spkrd_flags configured in /etc/rc.conf were not available
when constructing the command line arguments. The script structure
did not follow FreeBSD rc.d best practices for variable initialization
order.

Changed: Relocated rcorder comments (PROVIDE, REQUIRE, KEYWORD) to
appear after the explanatory header section while remaining parseable
by rcorder. Moved load_rc_config call to execute immediately after
basic variable setup and before command definition, ensuring
spkrd_flags from /etc/rc.conf is available. Added explicit default
value for spkrd_enable using the ${var:="default"} pattern following
FreeBSD conventions. Removed trailing whitespace in device path
comment line.

See: changelog/20251013-rc-script-boot-issue.md

Author: knz

changelog/20251013-rc-script-boot-issue.md

@@ -0,0 +1,42 @@
+# RC Script Boot Issue Investigation
+
+## Task Specification
+User reported that the spkrd daemon was not starting on boot with the provided rc.d script. They manually added rcorder comments and want verification that the script is now correct.
+
+## Initial Analysis
+The rc.d script now includes rcorder comments:
+- `PROVIDE: spkrd`
+- `REQUIRE: DAEMON`
+- `KEYWORD: shutdown`
+
+## Files to Review
+- `rc.d/spkrd`: FreeBSD service script
+
+## Current Status
+- Examining script for correctness
+- Need to verify rcorder comments are appropriate
+- Check for other potential boot startup issues
+
+## Issues Found
+1. **Variable loading order**: `load_rc_config` called after `command_args` definition, preventing `spkrd_flags` from being properly loaded from `/etc/rc.conf`
+2. **rcorder comment placement**: User prefers rcorder comments after the explanatory header comment
+
+## Implementation Plan
+
+### Fix 1: Correct Variable Loading Order
+Move `load_rc_config $name` to execute before `command_args` is set. Standard pattern:
+```sh
+. /etc/rc.subr
+name=spkrd
+rcvar=spkrd_enable
+load_rc_config $name  # Load user config first
+# Then set defaults and use variables
+```
+
+### Fix 2: Move rcorder Comments
+Place `PROVIDE`/`REQUIRE`/`KEYWORD` comments after the explanatory header block. This is supported by FreeBSD - rcorder scans the entire file for these special comments, they don't need to be at the top.
+
+## Changes Applied
+- Moved rcorder comments (lines 3-5) to after explanatory header (after line 34)
+- Moved `load_rc_config $name` to before `command` and `command_args` definitions
+- Added `: ${spkrd_enable:="NO"}` default for cleaner rc.conf integration

rc.d/spkrd

@@ -9,7 +9,7 @@
 #
 # Available flags:
 #   --port <port>           Server port (default: 1111)
-#   --device <path>         Speaker device path (default: /dev/speaker)  
+#   --device <path>         Speaker device path (default: /dev/speaker)
 #   --retry-timeout <secs>  Device retry timeout (default: 30)
 #   --daemon                Run as daemon (automatically added by rc.d)
 #   --pidfile <path>        PID file path (default: /var/run/spkrd.pid)
@@ -29,15 +29,22 @@
 #   - View logs: tail -f /var/log/daemon.log | grep spkrd
 #   - Non-root users: Use custom --pidfile (e.g., /tmp/spkrd.pid)
 
+# PROVIDE: spkrd
+# REQUIRE: DAEMON
+# KEYWORD: shutdown
+
 . /etc/rc.subr
 
 name=spkrd
 rcvar=spkrd_enable
 
+load_rc_config $name
+
+: ${spkrd_enable:="NO"}
+
 command="/usr/local/bin/${name}"
 pidfile="/var/run/${name}.pid"
 command_args="--daemon --pidfile ${pidfile} ${spkrd_flags}"
 required_files="/usr/local/bin/${name}"
 
-load_rc_config $name
 run_rc_command "$1"