Skip to content

Commit 07b003f

Browse files
authored
fix(analysis): Fix UI wording and gap sizes DEV-1195 (#6481)
### 📣 Summary Cleared up some confusing UI mistakes in the button wording and gap sizes. ### 👀 Preview steps 1. ℹ️ have an account and a project with NLP compatible submissions 2. Go to analysis tab in NLP 3. create a question 4. delete the question 5. 🔴 [on main] notice that the modal says "delete account" 6. 🟢 [on PR] notice that the modal just says "delete" 7. create a select question 8. add some options 5. 🔴 [on main] notice that there is a big gap between options 10. 🟢 notice that the gap is the same size as production (10px)
1 parent ef5fe05 commit 07b003f

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

jsapp/js/components/processing/analysis/editors/analysisQuestionEditor.component.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,8 @@ export default function AnalysisQuestionEditor(props: AnalysisQuestionEditorProp
201201

202202
{qaDefinition.additionalFieldNames && (
203203
// Hard coded left padding to account for the 32px icon size + 8px gap
204-
<Stack pl={'40px'}>
204+
// 0px gap because the children still did not get a mantine refactor so we must respect existing styles
205+
<Stack pl={'40px'} gap={'0px'}>
205206
{question.type === 'qual_auto_keyword_count' && (
206207
<KeywordSearchFieldsEditor
207208
questionUuid={question.uuid}

jsapp/js/components/processing/analysis/responseForms/responseWrapper.component.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export default function ResponseWrapper(props: ResponseWrapperProps) {
109109
</ButtonNew>
110110

111111
<ButtonNew size='md' onClick={deleteQuestion} variant='danger'>
112-
{t('Delete account')}
112+
{t('Delete')}
113113
</ButtonNew>
114114
</Group>
115115
</Stack>

0 commit comments

Comments
 (0)