Commit a832b0a
authored
refactor(mantine): migrate QA tags response form to mantine DEV-1168 (#6390)
### 💭 Notes
TLDR: Needed to create custom theme for mantine's `TagInput` as it has
some hacky styling that is different than our defaults.
Mantine's `TagInput` (and I suspect every other tag input library in
some way) has a "input" that's actually a div, which wraps around an
actual `<input>` element inside. This way it can display the tags in the
same wrapper, before where the user would actually type the tags in.
This means the default styles for mantine `<input>`'s can't apply here.
The div wrapper "input" needs `focus-within` rather than
`focus-visible`, as well as other default styles that we want to apply
to its wrapper div instead. It's probably easier to understand by
reading the code changes
### 👀 Preview steps
1. ℹ️ have an account and a project with NLP submissions
2. open NLP view
3. add a tags analysis question
5. 🟢 [on PR] notice that there is no functional differences between main1 parent c045506 commit a832b0a
File tree
4 files changed
+30
-19
lines changed- jsapp/js
- components/processing/analysis/responseForms
- theme/kobo
4 files changed
+30
-19
lines changedLines changed: 2 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | | - | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
| 63 | + | |
81 | 64 | | |
82 | 65 | | |
83 | 66 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
117 | 118 | | |
118 | 119 | | |
119 | 120 | | |
| 121 | + | |
120 | 122 | | |
121 | 123 | | |
0 commit comments