Skip to content

Commit 68a0803

Browse files
committed
Add null-safe condition in UnknownFieldsSupport, tweak java-docs, remove unused import
1 parent 6088075 commit 68a0803

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

src/main/java/com/kobylynskyi/graphql/codegen/mapper/RequestResponseDefinitionToDataModelMapper.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import static com.kobylynskyi.graphql.codegen.model.DataModelFields.GENERATED_ANNOTATION;
3030
import static com.kobylynskyi.graphql.codegen.model.DataModelFields.GENERATED_INFO;
3131
import static com.kobylynskyi.graphql.codegen.model.DataModelFields.GENERATE_ALL_METHOD_IN_PROJECTION;
32-
import static com.kobylynskyi.graphql.codegen.model.DataModelFields.GENERATE_SEALED_INTERFACES;
3332
import static com.kobylynskyi.graphql.codegen.model.DataModelFields.JAVA_DOC;
3433
import static com.kobylynskyi.graphql.codegen.model.DataModelFields.METHOD_NAME;
3534
import static com.kobylynskyi.graphql.codegen.model.DataModelFields.OPERATION_NAME;

src/main/java/com/kobylynskyi/graphql/codegen/mapper/UnknownFieldsSupport.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public interface UnknownFieldsSupport {
2424
* the instance of {@link ParameterDefinition}. {@link Optional#empty()} otherwise.
2525
*/
2626
default Optional<ParameterDefinition> createUnknownFields(MappingContext mappingContext) {
27-
if (mappingContext.isSupportUnknownFields()) {
27+
if (Boolean.TRUE.equals(mappingContext.isSupportUnknownFields())) {
2828
ParameterDefinition unknownFields = new ParameterDefinition();
2929
unknownFields.setName(mappingContext.getUnknownFieldsPropertyName());
3030
unknownFields.setOriginalName(mappingContext.getUnknownFieldsPropertyName());

src/main/java/com/kobylynskyi/graphql/codegen/model/builders/JavaDocBuilder.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ private JavaDocBuilder() {
2525
* Get java doc from description of the definition and it's extensions.
2626
* If no description is present in the definition and extension then return from comments
2727
*
28+
* @param extendedDefinition Extended GraphQL definition
29+
* @param <T> base type
30+
* @param <E> extension type
2831
* @return List of java docs
2932
*/
3033
public static <T extends NamedNode<T>, E extends T> List<String> build(
@@ -39,6 +42,9 @@ public static <T extends NamedNode<T>, E extends T> List<String> build(
3942
/**
4043
* Get java doc from description for the given definition
4144
*
45+
* @param extendedDefinition Extended GraphQL definition
46+
* @param <T> base type
47+
* @param <E> extension type
4248
* @return List of java docs
4349
*/
4450
public static <T extends NamedNode<T>, E extends T> List<String> buildFromDescription(
@@ -65,6 +71,9 @@ public static <T extends NamedNode<T>, E extends T> List<String> buildFromDescri
6571
/**
6672
* Get java doc from comments for the given definition
6773
*
74+
* @param extendedDefinition Extended GraphQL definition
75+
* @param <T> base type
76+
* @param <E> extension type
6877
* @return List of java docs
6978
*/
7079
public static <T extends NamedNode<T>, E extends T> List<String> buildFromComments(

0 commit comments

Comments
 (0)