Fix bad upmerge from phpGH-18464 (php#18666)

DanielEScherzer · web-flow · commit de785f91278f · 2025-05-26T12:40:11.000-07:00
This led to recursion being added to but not removed from internal constants.
diff --git a/Zend/zend_constants.c b/Zend/zend_constants.c
@@ -377,7 +377,6 @@ ZEND_API zval *zend_get_class_constant_ex(zend_string *class_name, zend_string *
 						/* Recursion protection only applied to user constants, GH-18463 */
 						CONST_PROTECT_RECURSION(c);
 					}
-					CONST_PROTECT_RECURSION(c);
 					zend_deprecated_class_constant(c, constant_name);
 					if (c->ce->type == ZEND_USER_CLASS) {
 						CONST_UNPROTECT_RECURSION(c);

Original file line number	Diff line number	Diff line change
`@@ -377,7 +377,6 @@ ZEND_API zval zend_get_class_constant_ex(zend_string class_name, zend_string *`
`377`	`377`	`/* Recursion protection only applied to user constants, GH-18463 */`
`378`	`378`	`CONST_PROTECT_RECURSION(c);`
`379`	`379`	`}`
`380`		`- CONST_PROTECT_RECURSION(c);`
`381`	`380`	`zend_deprecated_class_constant(c, constant_name);`
`382`	`381`	`if (c->ce->type == ZEND_USER_CLASS) {`
`383`	`382`	`CONST_UNPROTECT_RECURSION(c);`