From ef44673fb767bf5c3532f661ebf867f03654b049 Mon Sep 17 00:00:00 2001 From: Nader Eloshaiker Date: Wed, 20 Dec 2017 11:17:21 +0300 Subject: [PATCH 1/3] use hypot to calculate length --- SKTUtils/CGPoint+Extensions.swift | 2 +- SKTUtils/CGVector+Extensions.swift | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SKTUtils/CGPoint+Extensions.swift b/SKTUtils/CGPoint+Extensions.swift index 9904f75..f52c969 100644 --- a/SKTUtils/CGPoint+Extensions.swift +++ b/SKTUtils/CGPoint+Extensions.swift @@ -52,7 +52,7 @@ public extension CGPoint { * Returns the length (magnitude) of the vector described by the CGPoint. */ public func length() -> CGFloat { - return sqrt(x*x + y*y) + return hypot(x, y) } /** diff --git a/SKTUtils/CGVector+Extensions.swift b/SKTUtils/CGVector+Extensions.swift index 5474490..184d3c6 100644 --- a/SKTUtils/CGVector+Extensions.swift +++ b/SKTUtils/CGVector+Extensions.swift @@ -52,7 +52,7 @@ public extension CGVector { * Returns the length (magnitude) of the vector described by the CGVector. */ public func length() -> CGFloat { - return sqrt(dx*dx + dy*dy) + return hypot(dx + dy) } /** From 3a3802d95304ca13ab323eeb12c0fb18219ca566 Mon Sep 17 00:00:00 2001 From: Nader Eloshaiker Date: Wed, 20 Dec 2017 12:15:22 +0300 Subject: [PATCH 2/3] fixed comma separator --- SKTUtils/CGVector+Extensions.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SKTUtils/CGVector+Extensions.swift b/SKTUtils/CGVector+Extensions.swift index 184d3c6..dd5ab75 100644 --- a/SKTUtils/CGVector+Extensions.swift +++ b/SKTUtils/CGVector+Extensions.swift @@ -52,7 +52,7 @@ public extension CGVector { * Returns the length (magnitude) of the vector described by the CGVector. */ public func length() -> CGFloat { - return hypot(dx + dy) + return hypot(dx, dy) } /** From b23855996a17967788174c4ac75e51b3a3dfbb7e Mon Sep 17 00:00:00 2001 From: Nader Eloshaiker Date: Wed, 20 Dec 2017 12:17:08 +0300 Subject: [PATCH 3/3] replace deplicated M_PI with Double.pi --- SKTUtils/CGFloat+Extensions.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SKTUtils/CGFloat+Extensions.swift b/SKTUtils/CGFloat+Extensions.swift index 7b9104c..c7fcd11 100644 --- a/SKTUtils/CGFloat+Extensions.swift +++ b/SKTUtils/CGFloat+Extensions.swift @@ -23,7 +23,7 @@ import CoreGraphics /** The value of π as a CGFloat */ -let π = CGFloat(M_PI) +let π = CGFloat(Double.pi) public extension CGFloat { /**