- updates exception handling (redis)

kodeart · kodeart · commit 2cfe92115f59 · 2019-12-11T17:40:29.000+01:00
diff --git a/Client/CacheClientFactory.php b/Client/CacheClientFactory.php
@@ -12,6 +12,7 @@
 
 namespace Koded\Caching\Client;
 
+use Error;
 use Exception;
 use Koded\Caching\{Cache, CacheException};
 use Koded\Caching\Configuration\{MemcachedConfiguration, PredisConfiguration, RedisConfiguration};
@@ -136,7 +137,7 @@ private function newRedis(RedisConfiguration $conf): \Redis
         catch (\RedisException $e) {
             error_log('[Redis] ' . $e->getMessage());
             throw CacheException::withConnectionErrorFor('Redis');
-        } catch (Exception $e) {
+        } catch (Exception | Error $e) {
             throw CacheException::from($e);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`
`13`	`13`	`namespace Koded\Caching\Client;`
`14`	`14`
	`15`	`+use Error;`
`15`	`16`	`use Exception;`
`16`	`17`	`use Koded\Caching\{Cache, CacheException};`
`17`	`18`	`use Koded\Caching\Configuration\{MemcachedConfiguration, PredisConfiguration, RedisConfiguration};`
`@@ -136,7 +137,7 @@ private function newRedis(RedisConfiguration $conf): \Redis`
`136`	`137`	`catch (\RedisException $e) {`
`137`	`138`	`error_log('[Redis] ' . $e->getMessage());`
`138`	`139`	`throw CacheException::withConnectionErrorFor('Redis');`
`139`		`- } catch (Exception $e) {`
	`140`	`+ } catch (Exception \| Error $e) {`
`140`	`141`	`throw CacheException::from($e);`
`141`	`142`	`}`
`142`	`143`	`}`