chore:

- constructor cleanup
- adds the file/type in exception message

Author: kodeart

HeaderTrait.php

@@ -93,7 +93,7 @@ public function withAddedHeader($name, $value): static
         if (isset($instance->headersMap[$header = \strtolower($name)])) {
             $header                     = $instance->headersMap[$header];
             $instance->headers[$header] = \array_unique(
-                \array_merge_recursive($instance->headers[$header], $value)
+                @\array_merge_recursive($instance->headers[$header], $value)
             );
         } else {
             $instance->headersMap[$header] = $name;
@@ -203,15 +203,13 @@ protected function normalizeHeaderName(string $name): string
      *
      * @return array
      */
-    protected function normalizeHeaderValue(string $name, $value): array
+    protected function normalizeHeaderValue(string $name, mixed $value): array
     {
-        if (false === \is_array($value)) {
+//        if (false === \is_array($value)) {
             $value = (array)$value;
-        }
+//        }
         try {
-            if (empty($value = \array_map(function($v): string {
-                return \trim(\preg_replace('/\s+/', ' ', $v));
-            }, $value))) {
+            if (empty($value = \array_map(fn($v): string => \trim(\preg_replace('/\s+/', ' ', $v)), $value))) {
                 throw new \InvalidArgumentException(
                     \sprintf('The value for header "%s" cannot be empty', $name),
                     HttpStatus::BAD_REQUEST);

Tests/UploadedFileTest.php

@@ -32,9 +32,8 @@ public function test_constructor()
     /**
      * @dataProvider invalidTmpName
      */
-    public function test_stream_should_pass_when_file_is_null($resource)
+    public function test_should_fail_when_tmp_name_is_invalid($resource)
     {
-        $this->markTestSkipped('Check the PSR...');
         $this->expectException(InvalidArgumentException::class);
 
         $SUT = $this->prepareFile($resource);
@@ -98,15 +97,14 @@ protected function setUp(): void
 
     protected function tearDown(): void
     {
-        unlink($this->file);
+        @unlink($this->file);
         @unlink('/tmp/test-moved-to/filename.txt');
     }
 
     private function prepareFile($resource): UploadedFIle
     {
-        $file             = (include __DIR__ . '/fixtures/simple-file-array.php')['test'];
+        $file = (include __DIR__ . '/fixtures/simple-file-array.php')['test'];
         $file['tmp_name'] = $resource;
-
         return new UploadedFile($file);
     }
 }