- improved response headers parsing

Author: kodeart

Client/CurlClient.php

@@ -208,8 +208,10 @@ protected function getCurlError($resource): string
     protected function extractFromResponseHeaders($_, string $header): int
     {
         try {
-            [$k, $v] = explode(':', $header, 2);
-            $this->responseHeaders[$k] = $v;
+            [$k, $v] = explode(':', $header, 2) + [1 => null];
+            if (null !== $v) {
+                $this->responseHeaders[$k] = $v;
+            }
         } catch (Throwable $e) {
             /** NOOP **/
         } finally {

Client/PhpClient.php

@@ -168,21 +168,23 @@ protected function prepareOptions(): void
      */
     protected function extractFromResponseHeaders($response, &$headers, &$statusCode): void
     {
-        $_headers   = stream_get_meta_data($response)['wrapper_data'];
-        $statusCode = array_filter($_headers, function(string $header) {
-            return false !== stripos($header, 'HTTP/');
-        });
-
-        $statusCode = array_pop($statusCode) ?: 'HTTP/1.1 200 OK';
-        $statusCode = (int)(explode(' ', $statusCode)[1] ?? StatusCode::OK);
-
-        foreach ($_headers as $header) {
-            try {
-                [$k, $v] = explode(':', $header, 2);
+        try {
+            $_headers   = stream_get_meta_data($response)['wrapper_data'];
+            $statusCode = array_filter($_headers, function(string $header) {
+                return false !== stripos($header, 'HTTP/', 0);
+            });
+            $statusCode = array_pop($statusCode) ?: 'HTTP/1.1 200 OK';
+            $statusCode = (int)(explode(' ', $statusCode)[1] ?? StatusCode::OK);
+
+            foreach ($_headers as $header) {
+                [$k, $v] = explode(':', $header, 2) + [1 => null];
+                if (null === $v) {
+                    continue;
+                }
                 $headers[$k] = $v;
-            } catch (Throwable $e) {
-                continue;
             }
+        } finally {
+            unset($_headers, $header, $k, $v);
         }
     }
 }