- chore: replace alias join function with implode

Author: kodeart

Config.php

@@ -20,10 +20,10 @@
 use function file_get_contents;
 use function getcwd;
 use function getenv;
+use function implode;
 use function is_a;
 use function is_string;
 use function iterator_to_array;
-use function join;
 use function json_decode;
 use function parse_ini_file;
 use function parse_ini_string;
@@ -181,7 +181,7 @@ public function fromEnvironment(
             $value = getenv($variable);
             $data[] = $variable . '=' . (false === $value ? 'null' : $value);
         }
-        $data = parse_ini_string(join(PHP_EOL, $data), true, INI_SCANNER_TYPED) ?: [];
+        $data = parse_ini_string(implode(PHP_EOL, $data), true, INI_SCANNER_TYPED) ?: [];
         $this->import($this->filter($data, $namespace, $lowercase, $trim));
         return $this;
     }

ExtendedArguments.php

@@ -17,9 +17,9 @@
 use function array_push;
 use function array_slice;
 use function explode;
+use function implode;
 use function is_array;
 use function is_string;
-use function join;
 use function str_contains;
 
 /**
@@ -132,7 +132,7 @@ public function flatten(): static
         foreach ($iterator as $index => $value) {
             $indexes[$iterator->getDepth()] = $index;
             if (false === is_array($value)) {
-                $_ = join('.', array_slice($indexes, 0, $iterator->getDepth() + 1));
+                $_ = implode('.', array_slice($indexes, 0, $iterator->getDepth() + 1));
                 $flatten[$_] = $value;
             }
         }

functions.php

@@ -26,7 +26,7 @@
 use function date_create_immutable;
 use function getenv;
 use function htmlentities;
-use function join;
+use function implode;
 use function ord;
 use function preg_replace;
 use function preg_split;
@@ -78,16 +78,16 @@ function value(...$values): Data
 }
 
 /**
- * Do something with an object or array inside the callable,
- * and return that value.
+ * Do something with the $value (an object, array)
+ * inside the callable, and return that value.
  *
  * @param mixed $value The value that is tapped into the callback
  * @param callable|null $callable Callback that can modify the value
  * @return mixed The tapped value
  */
-function tap(mixed $value, callable $callable = null): mixed
+function tap(mixed $value, callable|null $callable = null): mixed
 {
-    if (false === is_null($callable)) {
+    if ($callable) {
         $callable($value);
         return $value;
     }
@@ -103,7 +103,7 @@ public function __call($method, $arguments) {
 }
 
 /**
- * Transforms simple CamelCaseName into camel_case_name (lower case underscored).
+ * Transforms CamelCaseName string into camel_case_name (lower case, underscored).
  *
  * @param string $string CamelCase string to be underscored
  * @return string Transformed string (for weird strings, you get what you deserve)
@@ -129,8 +129,8 @@ function error_log(string $func, string $message, mixed $data): void
 /**
  * Gets or sets environment variables.
  *
- * @param string|null $name
- * @param string [optional] $name The name of the env variable
+ * @param string|null $name The name of the env variable
+ * @param string|null $default The default value (NULL if not provided)
  * @param array|null $initialState
  * @return mixed The value for the env variable,
  *               or all variables if $name is not provided
@@ -291,7 +291,7 @@ function snake_to_camel_case(string $string): string
 function to_delimited_string(string $string, int $delimiter): string
 {
     $str = preg_split('~[^\p{L}\p{N}\']+~u', trim($string));
-    return join(chr($delimiter), $str);
+    return implode(chr($delimiter), $str);
 }
 
 /**
@@ -320,7 +320,7 @@ function xml_serialize(string $root, iterable $data): string
 /**
  * Unserialize an XML document into PHP array.
  * This function does not deal with magical conversions
- * of complicated XML structures.
+ * of complicated XML documents.
  *
  * @param string $xml The XML document to be decoded into array
  * @return array Decoded version of the XML string,

semver.php

@@ -63,7 +63,7 @@ function get_complete_version(array $version): array
 {
     if (empty($version)) {
         $version = match (true) {
-            defined('VERSION') && is_array(VERSION) => get_version_array(join('-', array_filter(VERSION))),
+            defined('VERSION') && is_array(VERSION) => get_version_array(implode('-', array_filter(VERSION))),
             is_file($version = __DIR__ . '/../../../VERSION'), // project dir relative to /vendor
             is_file($version = getcwd() . '/VERSION') => get_version_array(@file_get_contents($version)),
             // @codeCoverageIgnoreStart