- update: added mote tests for tap() function

Author: kodeart

tests/TapFunctionTest.php

@@ -5,6 +5,7 @@
 use Error;
 use Koded\Stdlib\Arguments;
 use Koded\Stdlib\Config;
+use Koded\Stdlib\ExtendedArguments;
 use Koded\Stdlib\Tapped;
 use PHPUnit\Framework\TestCase;
 use function Koded\Stdlib\tap;
@@ -15,9 +16,9 @@ class TapFunctionTest extends TestCase
 
     public function test_object_with_callback()
     {
-        $conf = tap(new Config, function(Config $c) {
-            $c->silent(true);
-            $c->foo = 'bar';
+        $conf = tap(new Config, function(Config $conf) {
+            $conf->silent(true);
+            $conf->foo = 'bar';
         });
 
         $this->assertInstanceOf(Config::class, $conf);
@@ -34,19 +35,41 @@ public function test_object_without_callback()
         $this->assertSame('bar', $conf->foo);
     }
 
+    public function test_extended_arguments()
+    {
+        $args = tap(new ExtendedArguments, function(ExtendedArguments $args) {
+            $args
+                ->import((array)null)
+                ->set('foo', 'bar');
+        });
+
+        $this->assertSame('bar', $args->get('foo'));
+    }
+
     public function test_with_array_value()
     {
-        $arr = tap([], function(&$data) {
-            $data['foo'] = 'bar';
+        $arr = tap([], function(&$arr) {
+            $arr['foo'] = 'bar';
         });
 
         $this->assertSame(['foo' => 'bar'], $arr);
     }
 
+    public function test_array_value_without_callback()
+    {
+        $original = [];
+        $arr = tap($original);
+
+        $original['foo'] = 'bar';
+
+        $this->assertSame(['foo' => 'bar'], $original);
+        $this->assertInstanceOf(Tapped::class, $arr);
+    }
+
     public function test_chainable_methods()
     {
-        $data = tap(new Arguments(['foo' => 'bar']), function ($args) {
-            $args
+        $data = tap(new Arguments(['foo' => 'bar']), function ($data) {
+            $data
                 ->set('bar', [1, 2 , 3])
                 ->delete('bar.1')
                 ->import([
@@ -68,19 +91,18 @@ public function test_chainable_methods()
         );
     }
 
-    public function test_with_primitive_value()
+    public function test_primitive_by_value()
     {
-        $val1 = tap(42, function($v) {
-            $v = 'fubar';
-        });
-        $this->assertSame(42, $val1,
-            'The tapped value is not changed');
+        $value = tap(42, function($value) { $value = 'fubar'; });
+        $this->assertSame(42, $value,
+            'The tapped value is not changed (passed by value)');
+    }
 
-        $val2 = tap(42, function(&$v) {
-            $v = 'fubar';
-        });
-        $this->assertSame('fubar', $val2,
-            'The tapped value is changed (passed by reference)');
+    public function test_primitive_by_reference()
+    {
+        $value = tap(42, function(&$value) { $value = 'fubar'; });
+        $this->assertSame('fubar', $value,
+            'The tapped value is changed (passed as reference)');
     }
 
     public function test_unreasonable_use()