Skip to content

Commit d00f952

Browse files
authored
fix create/update helm service from template panic (#4290)
Signed-off-by: Patrick Zhao <[email protected]>
1 parent c6a62d7 commit d00f952

File tree

1 file changed

+6
-1
lines changed
  • pkg/microservice/aslan/core/service/service

1 file changed

+6
-1
lines changed

pkg/microservice/aslan/core/service/service/helm.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -746,6 +746,11 @@ func createOrUpdateHelmServiceFromChartTemplate(templateArgs *CreateFromChartTem
746746
return nil, err
747747
}
748748

749+
loadPath := ""
750+
if args.ValuesData != nil && args.ValuesData.GitRepoConfig != nil && len(args.ValuesData.GitRepoConfig.ValuesPaths) > 0 {
751+
loadPath = args.ValuesData.GitRepoConfig.ValuesPaths[0]
752+
}
753+
749754
svc, errCreate := createOrUpdateHelmService(
750755
fsTree,
751756
&helmServiceCreationArgs{
@@ -767,7 +772,7 @@ func createOrUpdateHelmServiceFromChartTemplate(templateArgs *CreateFromChartTem
767772
AutoSync: args.AutoSync,
768773
Production: args.Production,
769774
// TODO: FIX valuePaths, it should be a single value in some situation
770-
LoadPath: args.ValuesData.GitRepoConfig.ValuesPaths[0],
775+
LoadPath: loadPath,
771776
}, force,
772777
logger,
773778
)

0 commit comments

Comments
 (0)