hdhomerun library update, source and handling thereof?

[AlwinEsch]

It's about which source of the hdhomerun library we use for the add-on.

We are currently using https://github.com/Silicondust/libhdhomerun. The changes are only saved there as commits and never as releases. In addition, the source always lags behind their website there.

Normally I would not care much, only when I look at Ubuntu packages as a comparison (https://packages.ubuntu.com/hirsute/libhdhomerun4), I see the latest with https://download.silicondust.com/hdhomerun/libhdhomerun_20210624.tgz. On github they have 20201023 and increase to new as request opened here Silicondust/libhdhomerun#30, but not was come in.

Only when I see the Ubuntu as the source source version is in front of the addon do I ask myself the question. Otherwise they are always lagging behind with versions on Ubuntu (related to other libraries).

Should we use:

• Like now to take as released URL the sha sum id like https://github.com/Silicondust/libhdhomerun/archive/7c54382fb681d03888b469033e50bebaf4ce6bce.tar.gz?
• Take as URL from https://www.silicondust.com/support/linux/ with now https://download.silicondust.com/hdhomerun/libhdhomerun_20210624.tgz?
• Or to to move newest version to our ftp mirror to have always available?

Try to keep the addons up to date as far as possible so that they don't die. Even if there are no more direct maintainers for some addons, maybe someone will come again hopefully 😅.

[djp952]

Just my opinion, but I think Kodi would be best served by mirroring the code, either externally to the PVR addon via the ftp mirror, or by simply copying it into the PVR addon code itself. As noted, the vendor does not do a great job of maintaining their github repository. There are open PRs and open Issues that have long since been resolved so it's really not a good source.

I maintain a fork of the github repo myself and sporadically check for updates from time to time when it occurs to me, and manually merge them when found, since I need a patched library. I'm considering just killing the fork and putting the code in my project as "source" since it would be easier to maintain.

Changes/updates to this library code are infrequent and generally not "transparent" in nature. To that end, having a potential need to diff/assess/merge as opposed to always preferred blind update leads me to think it would be best to just add the code to the PVR project and expect somebody to periodically update it if/when needed. Given my experience/history with this library code I feel that this would be your best and most stable path forward; don't count on being notified and do it yourself.

[phunkyfish]

If we use the same as Ubuntu at least we there is some consensus.

[heitbaum]

I closed my PR in Silicondust/libhdhomerun#30 as it has been subsequently synced up:

• Silicondust/libhdhomerun@032728a
• Silicondust/libhdhomerun@7d4e2d3