Merge pull request #147 from koenbeuk/fixed-memory-leak

Fixed a possible memory leak caused by exceptions from pooled DB contexts

Author: koenbeuk

src/EntityFrameworkCore.Triggered/Internal/AfterSaveFailedTriggerDescriptor.cs

@@ -10,7 +10,7 @@ public sealed class AfterSaveFailedTriggerDescriptor : ITriggerTypeDescriptor
         readonly Func<object, object, Exception?, CancellationToken, Task> _invocationDelegate;
         readonly Type _triggerType;
 
-        public AfterSaveFailedTriggerDescriptor(Type entityType, Exception exception)
+        public AfterSaveFailedTriggerDescriptor(Type entityType)
         {
             var triggerType = typeof(IAfterSaveFailedTrigger<>).MakeGenericType(entityType);
             var triggerMethod = triggerType.GetMethod(nameof(IAfterSaveFailedTrigger<object>.AfterSaveFailed));

src/EntityFrameworkCore.Triggered/TriggerSession.cs

@@ -201,7 +201,7 @@ public Task RaiseAfterSaveFailedTriggers(Exception exception, CancellationToken
                 _afterSaveFailedTriggerContextDiscoveryStrategy = new NonCascadingTriggerContextDiscoveryStrategy("AfterSaveFailed");
             }
 
-            return RaiseTriggers(typeof(IAfterSaveFailedTrigger<>), exception, _afterSaveFailedTriggerContextDiscoveryStrategy, entityType => new AfterSaveFailedTriggerDescriptor(entityType, exception), cancellationToken);
+            return RaiseTriggers(typeof(IAfterSaveFailedTrigger<>), exception, _afterSaveFailedTriggerContextDiscoveryStrategy, entityType => new AfterSaveFailedTriggerDescriptor(entityType), cancellationToken);
         }
 
         public async Task RaiseAfterSaveFailedCompletedTriggers(Exception exception, CancellationToken cancellationToken)

test/EntityFrameworkCore.Triggered.Tests/Internal/AfterSaveFailedTriggerDescriptorTests.cs

@@ -14,7 +14,7 @@ public void TriggerType_ReturnsConstructuredTriggerType()
         {
             var entityType = typeof(string);
             var exception = new Exception();
-            var subject = new AfterSaveFailedTriggerDescriptor(entityType, exception);
+            var subject = new AfterSaveFailedTriggerDescriptor(entityType);
 
             Assert.Equal(typeof(IAfterSaveFailedTrigger<string>), subject.TriggerType);
         }
@@ -25,7 +25,7 @@ public async Task Execute_ForwardsCall()
             var entityType = typeof(string);
             var exception = new Exception();
             var triggerStub = new TriggerStub<string>();
-            var subject = new AfterSaveFailedTriggerDescriptor(entityType, exception);
+            var subject = new AfterSaveFailedTriggerDescriptor(entityType);
 
             await subject.Invoke(triggerStub, new TriggerContextStub<string>(), exception, default);