Skip to content

Commit dd2e2ce

Browse files
committed
Renamed Before/AfterXXX Started to Completed
1 parent 7fdde04 commit dd2e2ce

File tree

18 files changed

+100
-100
lines changed

18 files changed

+100
-100
lines changed

src/EntityFrameworkCore.Triggered.Abstractions/ITriggerSession.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ public interface ITriggerSession : IDisposable
1111
/// </summary>
1212
void DiscoverChanges();
1313
Task RaiseBeforeSaveStartingTriggers(CancellationToken cancellationToken = default);
14-
Task RaiseBeforeSaveStartedTriggers(CancellationToken cancellationToken = default);
14+
Task RaiseBeforeSaveCompletedTriggers(CancellationToken cancellationToken = default);
1515
Task RaiseAfterSaveFailedStartingTriggers(Exception exception, CancellationToken cancellationToken = default);
16-
Task RaiseAfterSaveFailedStartedTriggers(Exception exception, CancellationToken cancellationToken = default);
16+
Task RaiseAfterSaveFailedCompletedTriggers(Exception exception, CancellationToken cancellationToken = default);
1717
Task RaiseAfterSaveStartingTriggers(CancellationToken cancellationToken = default);
18-
Task RaiseAfterSaveStartedTriggers(CancellationToken cancellationToken = default);
18+
Task RaiseAfterSaveCompletedTriggers(CancellationToken cancellationToken = default);
1919
/// <summary>
2020
/// Makes a snapshot of all changes in the DbContext and invokes BeforeSaveTriggers recursively based on the recursive settings until all changes have been processed
2121
/// </summary>

src/EntityFrameworkCore.Triggered.Abstractions/Lyfecycles/IAfterSaveStartedTrigger.cs renamed to src/EntityFrameworkCore.Triggered.Abstractions/Lyfecycles/IAfterSaveCompletedTrigger.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33

44
namespace EntityFrameworkCore.Triggered.Lyfecycles
55
{
6-
public interface IAfterSaveStartedTrigger
6+
public interface IAfterSaveCompletedTrigger
77
{
8-
Task AfterSaveStarted(CancellationToken cancellationToken);
8+
Task AfterSaveCompleted(CancellationToken cancellationToken);
99
}
1010
}
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
using System;
2+
using System.Threading;
3+
using System.Threading.Tasks;
4+
5+
namespace EntityFrameworkCore.Triggered.Lyfecycles
6+
{
7+
public interface IAfterSaveFailedCompletedTrigger
8+
{
9+
Task AfterSaveFailedCompleted(Exception exception, CancellationToken cancellationToken);
10+
}
11+
}

src/EntityFrameworkCore.Triggered.Abstractions/Lyfecycles/IAfterSaveFailedStartedTrigger.cs

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/EntityFrameworkCore.Triggered.Abstractions/Lyfecycles/IBeforeSaveStartedTrigger.cs renamed to src/EntityFrameworkCore.Triggered.Abstractions/Lyfecycles/IBeforeSaveCompletedTrigger.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33

44
namespace EntityFrameworkCore.Triggered.Lyfecycles
55
{
6-
public interface IBeforeSaveStartedTrigger
6+
public interface IBeforeSaveCompletedTrigger
77
{
8-
Task BeforeSaveStarted(CancellationToken cancellationToken);
8+
Task BeforeSaveCompleted(CancellationToken cancellationToken);
99
}
1010
}

src/EntityFrameworkCore.Triggered.Transactions.Abstractions/Lifecycles/IBeforeCommitStartedTrigger.cs renamed to src/EntityFrameworkCore.Triggered.Transactions.Abstractions/Lifecycles/IAfterCommitCompletedTrigger.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77

88
namespace EntityFrameworkCore.Triggered.Transactions.Abstractions.Lifecycles
99
{
10-
public interface IBeforeCommitStartedTrigger
10+
public interface IAfterCommitCompletedTrigger
1111
{
12-
Task BeforeCommitStarted(CancellationToken cancellationToken);
12+
Task AfterCommitCompleted(CancellationToken cancellationToken);
1313
}
1414
}

src/EntityFrameworkCore.Triggered.Transactions.Abstractions/Lifecycles/IAfterCommitStartedTrigger.cs renamed to src/EntityFrameworkCore.Triggered.Transactions.Abstractions/Lifecycles/IBeforeCommitCompletedTrigger.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77

88
namespace EntityFrameworkCore.Triggered.Transactions.Abstractions.Lifecycles
99
{
10-
public interface IAfterCommitStartedTrigger
10+
public interface IBeforeCommitCompletedTrigger
1111
{
12-
Task AfterCommitStarted(CancellationToken cancellationToken);
12+
Task BeforeCommitCompleted(CancellationToken cancellationToken);
1313
}
1414
}

src/EntityFrameworkCore.Triggered.Transactions/Extensions/TriggersContextOptionsBuilderExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ public static TriggersContextOptionsBuilder UseTransactionTriggers(this Triggers
2020
.AddTriggerType(typeof(IBeforeRollbackTrigger<>))
2121
.AddTriggerType(typeof(IAfterRollbackTrigger<>))
2222
.AddTriggerType(typeof(IBeforeCommitStartingTrigger))
23-
.AddTriggerType(typeof(IBeforeCommitStartedTrigger))
23+
.AddTriggerType(typeof(IBeforeCommitCompletedTrigger))
2424
.AddTriggerType(typeof(IAfterCommitStartingTrigger))
25-
.AddTriggerType(typeof(IAfterCommitStartedTrigger));
25+
.AddTriggerType(typeof(IAfterCommitCompletedTrigger));
2626
}
2727
}
2828
}

src/EntityFrameworkCore.Triggered.Transactions/TriggeredSessionExtensions.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public static async Task RaiseBeforeCommitStartingTriggers(this ITriggerSession
9999
}
100100
}
101101

102-
public static async Task RaiseBeforeCommitStartedTriggers(this ITriggerSession triggerSession, CancellationToken cancellationToken = default)
102+
public static async Task RaiseBeforeCommitCompletedTriggers(this ITriggerSession triggerSession, CancellationToken cancellationToken = default)
103103
{
104104
if (triggerSession == null)
105105
{
@@ -111,11 +111,11 @@ public static async Task RaiseBeforeCommitStartedTriggers(this ITriggerSession t
111111
throw new InvalidOperationException("Method is implemented for concrete TriggerSessions only");
112112
}
113113

114-
var triggers = typedTriggerSession.DiscoveryService.ServiceProvider.GetServices<IBeforeCommitStartedTrigger>();
114+
var triggers = typedTriggerSession.DiscoveryService.ServiceProvider.GetServices<IBeforeCommitCompletedTrigger>();
115115

116116
foreach (var trigger in triggers)
117117
{
118-
await trigger.BeforeCommitStarted(cancellationToken);
118+
await trigger.BeforeCommitCompleted(cancellationToken);
119119
}
120120
}
121121

@@ -139,7 +139,7 @@ public static async Task RaiseAfterCommitStartingTriggers(this ITriggerSession t
139139
}
140140
}
141141

142-
public static async Task RaiseAfterCommitStartedTriggers(this ITriggerSession triggerSession, CancellationToken cancellationToken = default)
142+
public static async Task RaiseAfterCommitCompletedTriggers(this ITriggerSession triggerSession, CancellationToken cancellationToken = default)
143143
{
144144
if (triggerSession == null)
145145
{
@@ -151,11 +151,11 @@ public static async Task RaiseAfterCommitStartedTriggers(this ITriggerSession tr
151151
throw new InvalidOperationException("Method is implemented for concrete TriggerSessions only");
152152
}
153153

154-
var triggers = typedTriggerSession.DiscoveryService.ServiceProvider.GetServices<IAfterCommitStartedTrigger>();
154+
var triggers = typedTriggerSession.DiscoveryService.ServiceProvider.GetServices<IAfterCommitCompletedTrigger>();
155155

156156
foreach (var trigger in triggers)
157157
{
158-
await trigger.AfterCommitStarted(cancellationToken);
158+
await trigger.AfterCommitCompleted(cancellationToken);
159159
}
160160
}
161161

src/EntityFrameworkCore.Triggered/Infrastructure/Internal/TriggersOptionExtension.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,11 @@ public TriggersOptionExtension()
103103
typeof(IAfterSaveTrigger<>),
104104
typeof(IAfterSaveFailedTrigger<>),
105105
typeof(IBeforeSaveStartingTrigger),
106-
typeof(IBeforeSaveStartedTrigger),
106+
typeof(IBeforeSaveCompletedTrigger),
107107
typeof(IAfterSaveFailedStartingTrigger),
108-
typeof(IAfterSaveFailedStartedTrigger),
108+
typeof(IAfterSaveFailedCompletedTrigger),
109109
typeof(IAfterSaveStartingTrigger),
110-
typeof(IAfterSaveStartedTrigger)
110+
typeof(IAfterSaveCompletedTrigger)
111111
};
112112
}
113113

0 commit comments

Comments
 (0)