HBX-3169: Update the use of H2 in the Maven integration tests to 2.4.240 (hibernate#5629)

  - Handle the 'generateHbm' integration test
  - Handle the 'generateDao' integration test
  - Handle the 'hbm2ddl' integration test
  - Handle the 'hbm2java' integration test
  - Properly fail with a MojoFailureException when the properties file is not found
  - Handle the noProperties case
  - Some additional cleanup of the integration tests
  - Remove the unneeded reveng.xml files from the integration tests

Author: koentsje

maven/src/main/java/org/hibernate/tool/maven/AbstractGenerationMojo.java

@@ -98,11 +98,7 @@ public void execute() throws MojoFailureException {
     		Thread.currentThread().setContextClassLoader(createExporterClassLoader(original));
 	        getLog().info("Starting " + this.getClass().getSimpleName() + "...");
 	        RevengStrategy strategy = setupReverseEngineeringStrategy();
-	        if (propertyFile.exists()) {
-	        	executeExporter(createJdbcDescriptor(strategy, loadPropertiesFile()));
-	        } else {
-	        	getLog().info("Property file '" + propertyFile + "' cannot be found, aborting...");
-	        }
+            executeExporter(createJdbcDescriptor(strategy, loadPropertiesFile()));
 	        getLog().info("Finished " + this.getClass().getSimpleName() + "!");
     	} finally {
     		Thread.currentThread().setContextClassLoader(original);
@@ -136,8 +132,10 @@ private Properties loadPropertiesFile() throws MojoFailureException {
             result.load(is);
             return result;
         } catch (FileNotFoundException e) {
+            getLog().error("Property file '" + propertyFile + "' cannot be found, aborting...");
             throw new MojoFailureException(propertyFile + " not found.", e);
         } catch (IOException e) {
+            getLog().error("Property file '" + propertyFile + "' cannot be loaded, aborting...");
             throw new MojoFailureException("Problem while loading " + propertyFile, e);
         }
     }

test/maven/pom.xml

@@ -49,8 +49,7 @@
                     <cloneProjectsTo>${project.build.directory}/it</cloneProjectsTo>
                     <settingsFile>src/it/settings.xml</settingsFile>
                     <localRepositoryPath>${project.build.directory}/local-repo</localRepositoryPath>
-                    <postBuildHookScript>verify</postBuildHookScript>
-                    <goal>install</goal>
+                    <goal>generate-sources</goal>
                 </configuration>
                 <executions>
                     <execution>
@@ -60,7 +59,14 @@
                         </goals>
                     </execution>
                 </executions>
-            </plugin>  
+                <dependencies>
+                    <dependency>
+                        <groupId>com.h2database</groupId>
+                        <artifactId>h2</artifactId>
+                        <version>${h2.version}</version>
+                    </dependency>
+                </dependencies>
+             </plugin>
         </plugins>
     </build>
 

test/maven/src/it/generateHbm/invoker.properties

@@ -8,13 +8,14 @@
     <artifactId>hbm2ddl</artifactId>
     <version>0.0.1-SNAPSHOT</version>
 
-    <properties>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
-
-        <java.version>1.8</java.version>
-        <h2.version>1.4.195</h2.version>
-     </properties>
+    <dependencies>
+        <dependency>
+            <!-- DB Driver of your choice -->
+            <groupId>com.h2database</groupId>
+            <artifactId>h2</artifactId>
+            <version>@h2.version@</version>
+        </dependency>
+    </dependencies>
 
     <build>
         <plugins>
@@ -35,17 +36,6 @@
                         </configuration>
                      </execution>
                 </executions>
-                <configuration>
-                    <revengFile>${project.basedir}/src/main/resources/hibernate.reveng.xml</revengFile>
-                </configuration>
-                <dependencies>
-                    <dependency>
-                        <!-- DB Driver of your choice -->
-                        <groupId>com.h2database</groupId>
-                        <artifactId>h2</artifactId>
-                        <version>${h2.version}</version>
-                    </dependency>
-                </dependencies>
             </plugin>
         </plugins>
     </build>

test/maven/src/it/generateHbm/pom.xml

@@ -1,5 +1,3 @@
-import java.io.*;
-
 File file = new File(basedir, "target/generated-sources/Person.hbm.xml");
 if (!file.isFile()) {
     throw new FileNotFoundException("Could not find generated HBM file: " + file);

test/maven/src/it/generateHbm/verify.groovy renamed to test/maven/src/it/generateHbm/postbuild.bsh

@@ -0,0 +1,9 @@
+import java.sql.DriverManager;
+import java.sql.Connection;
+
+String JDBC_CONNECTION = "jdbc:h2:" + basedir + "/test";
+String CREATE_PERSON_TABLE = "create table PERSON (ID int not null, NAME varchar(20), primary key (ID))";
+
+Connection connection = DriverManager.getConnection(JDBC_CONNECTION);
+connection.createStatement().execute(CREATE_PERSON_TABLE);
+connection.close();

test/maven/src/it/generateHbm/prebuild.bsh

@@ -1,7 +1,4 @@
-hibernate.dialect=org.hibernate.dialect.H2Dialect
 hibernate.connection.driver_class=org.h2.Driver
-hibernate.connection.url=jdbc:h2:./test;DB_CLOSE_ON_EXIT=FALSE
-hibernate.connection.username=sa
-hibernate.connection.password=
-hibernate.connection.pool_size=1
-hibernate.show_sql=true
+hibernate.connection.url=jdbc:h2:./test
+hibernate.default_catalog=TEST
+hibernate.default_schema=PUBLIC