core: Undo some changes to Opaque

to reduce the amount of changes in dCache#162

Signed-off-by: Christian Kohlschütter <[email protected]>

Author: kohlschuetter

core/src/main/java/org/dcache/nfs/util/Opaque.java

@@ -199,7 +199,7 @@ default void putBytes(ByteBuffer buf) {
     public class OpaqueImpl implements Opaque {
         final byte[] _opaque;
 
-        protected OpaqueImpl(byte[] opaque) {
+        OpaqueImpl(byte[] opaque) {
             _opaque = opaque;
         }
 
@@ -392,13 +392,7 @@ public boolean equals(Object o) {
                 }
                 return true;
             } else {
-                Opaque other = (Opaque) o;
-                for (int i = index, n = index + length, oi = 0; i < n; i++, oi++) {
-                    if (buf.get(i) != other.byteAt(oi)) {
-                        return false;
-                    }
-                }
-                return true;
+                return toImmutableOpaque().equals(o);
             }
         }