fix(core): send hint when arg prompt timeout, fix #1284

Author: shigma

packages/core/src/command/validate.ts

@@ -1,3 +1,4 @@
+import { isNullable } from 'cosmokit'
 import { Context } from '../context'
 import { Argv } from './parser'
 
@@ -39,6 +40,9 @@ export default function validate(ctx: Context) {
           session.text(`commands.${command.name}.arguments.${decl.name}`),
         ]))
         const source = await session.prompt()
+        if (isNullable(source)) {
+          return sendHint('internal.insufficient-arguments', decl.name)
+        }
         args.push(Argv.parseValue(source, 'argument', argv, decl))
         index++
       }

packages/core/src/i18n.ts

@@ -85,6 +85,7 @@ export class I18n {
   private* set(locale: string, prefix: string, value: I18n.Node): Generator<string> {
     if (typeof value === 'object' && value && !prefix.includes('@')) {
       for (const key in value) {
+        if (key.startsWith('_')) continue
         yield* this.set(locale, prefix + key + '.', value[key])
       }
     } else if (prefix.includes('@')) {

packages/core/tests/runtime.spec.ts

@@ -1,6 +1,7 @@
 import { App, User, Channel, Command, sleep } from 'koishi'
 import mock, { DEFAULT_SELF_ID } from '@koishijs/plugin-mock'
 import memory from '@koishijs/plugin-database-memory'
+import { install } from '@sinonjs/fake-timers'
 
 const app = new App()
 
@@ -224,6 +225,19 @@ describe('Runtime', () => {
       await client4.shouldReply('bar baz', 'cmd1:bar baz')
       await client4.shouldReply('cmd1 foo bar', '存在多余参数，输入帮助以查看用法。')
       cmd1.config.showWarning = false
+      cmd1.config.checkArgCount = false
+    })
+
+    it('check arg count: timeout', async () => {
+      const clock = install()
+      cmd1.config.checkArgCount = true
+      cmd1.config.showWarning = true
+      await client4.shouldReply('cmd1', '请发送arg1。')
+      await clock.runAllAsync()
+      await client4.shouldReply('', '缺少参数，输入帮助以查看用法。')
+      cmd1.config.showWarning = false
+      cmd1.config.checkArgCount = false
+      clock.uninstall()
     })
 
     it('check unknown option', async () => {