fix: Add explicitly null checks (#22)

* fix(job): Add explicitly null check

* fix(step): Add explicitly null check

* fix(on): Add explicitly null check

* fix(on): Added event name conversion

* fix(job): Add tests for job

* chore(workflow): Add tests for workflow

* fix: fix

Author: koki-develop

lib/package/job.spec.ts

@@ -2,12 +2,78 @@ import { describe, expect, test } from "bun:test";
 import { Job } from "./job";
 
 describe("Job", () => {
-  test("simple job", () => {
-    const job = new Job("test", { runsOn: "ubuntu-latest" });
-    job.run("echo 'Hello, world!'");
-    expect(job.toJSON()).toEqual({
-      "runs-on": "ubuntu-latest",
-      steps: [{ run: "echo 'Hello, world!'" }],
-    });
+  test.each<[Job, Record<string, unknown>]>([
+    [
+      new Job("test", { runsOn: "ubuntu-latest" }).run("echo 'Hello, world!'"),
+      {
+        "runs-on": "ubuntu-latest",
+        steps: [{ run: "echo 'Hello, world!'" }],
+      },
+    ],
+    [
+      new Job("test", {
+        runsOn: "ubuntu-latest",
+        permissions: {
+          contents: "read",
+          pullRequests: "write",
+        },
+      }),
+      {
+        "runs-on": "ubuntu-latest",
+        permissions: {
+          contents: "read",
+          "pull-requests": "write",
+        },
+        steps: [],
+      },
+    ],
+    [
+      new Job("test", {
+        runsOn: "ubuntu-latest",
+        timeoutMinutes: 10,
+      }),
+      {
+        "runs-on": "ubuntu-latest",
+        "timeout-minutes": 10,
+        steps: [],
+      },
+    ],
+    [
+      new Job("test", {
+        runsOn: "ubuntu-latest",
+        outputs: {
+          "output-name": "output-value",
+        },
+      }).run("echo 'Hello, world!'"),
+      {
+        "runs-on": "ubuntu-latest",
+        outputs: { "output-name": "output-value" },
+        steps: [{ run: "echo 'Hello, world!'" }],
+      },
+    ],
+    [
+      new Job("test", {
+        runsOn: "ubuntu-latest",
+        needs: "job-name",
+      }).run("echo 'Hello, world!'"),
+      {
+        "runs-on": "ubuntu-latest",
+        needs: "job-name",
+        steps: [{ run: "echo 'Hello, world!'" }],
+      },
+    ],
+    [
+      new Job("test", {
+        runsOn: "ubuntu-latest",
+        if: "always()",
+      }).run("echo 'Hello, world!'"),
+      {
+        "runs-on": "ubuntu-latest",
+        if: "always()",
+        steps: [{ run: "echo 'Hello, world!'" }],
+      },
+    ],
+  ])("job.toJSON(%j) -> %j", (job, expected) => {
+    expect(job.toJSON()).toEqual(expected);
   });
 });

lib/package/job.ts

@@ -52,19 +52,19 @@ export class Job {
     return {
       "runs-on": this._config.runsOn,
 
-      ...(this._config.permissions && {
+      ...(this._config.permissions != null && {
         permissions: permissionsJSON(this._config.permissions),
       }),
 
-      ...(this._config.timeoutMinutes && {
+      ...(this._config.timeoutMinutes != null && {
         "timeout-minutes": this._config.timeoutMinutes,
       }),
 
-      ...(this._config.outputs && { outputs: this._config.outputs }),
+      ...(this._config.outputs != null && { outputs: this._config.outputs }),
 
-      ...(this._config.needs && { needs: this._config.needs }),
+      ...(this._config.needs != null && { needs: this._config.needs }),
 
-      ...(this._config.if && { if: this._config.if }),
+      ...(this._config.if != null && { if: this._config.if }),
 
       steps: this._steps.map((step) => stepJSON(step)),
     };