Extract conflict exception

Author: koldakov

futuramaapi/apps/fastapi.py

@@ -100,12 +100,17 @@ def _setup_static(self) -> None:
 
     def _exception_handler(self, _: Request, exc) -> Response:
         from futuramaapi.routers.services import (  # noqa: PLC0415
+            ConflictError,
             NotFoundError,
             ServiceError,
             UnauthorizedError,
         )
 
         exception_to_value: dict[type[ServiceError], _ExceptionValue] = {
+            ConflictError: _ExceptionValue(
+                status_code=status.HTTP_409_CONFLICT,
+                default_message="Conflict",
+            ),
             UnauthorizedError: _ExceptionValue(
                 status_code=status.HTTP_401_UNAUTHORIZED,
                 default_message="Unauthorized",

futuramaapi/routers/services/__init__.py

@@ -2,6 +2,7 @@
     BaseService,
     BaseSessionService,
     BaseUserAuthenticatedService,
+    ConflictError,
     NotFoundError,
     ServiceError,
     UnauthorizedError,
@@ -13,6 +14,7 @@
     "BaseSessionService",
     "BaseTemplateService",
     "BaseUserAuthenticatedService",
+    "ConflictError",
     "NotFoundError",
     "ServiceError",
     "UnauthorizedError",

futuramaapi/routers/services/_base.py

@@ -32,6 +32,10 @@ class NotFoundError(ServiceError):
     """Not Found Error."""
 
 
+class ConflictError(ServiceError):
+    """Conflict Error."""
+
+
 class BaseService[TResponse](BaseModel, ABC):
     context: dict[str, Any] | None = None
 

futuramaapi/routers/services/favorites/create_favorite_character.py

@@ -1,10 +1,9 @@
 from asyncpg import UniqueViolationError
-from fastapi import HTTPException, status
 from sqlalchemy import Insert, Result, insert, select
 from sqlalchemy.exc import IntegrityError
 
 from futuramaapi.repositories.models import CharacterModel, FavoriteCharacterModel
-from futuramaapi.routers.services import BaseUserAuthenticatedService, NotFoundError
+from futuramaapi.routers.services import BaseUserAuthenticatedService, ConflictError, NotFoundError
 
 
 class CreateFavoriteCharacterService(BaseUserAuthenticatedService[None]):
@@ -26,10 +25,7 @@ async def process(self) -> None:
             await self.session.rollback()
 
             if err.orig.sqlstate == UniqueViolationError.sqlstate:
-                raise HTTPException(
-                    status_code=status.HTTP_409_CONFLICT,
-                    detail="Character is already in favorites",
-                ) from None
+                raise ConflictError("Character is already in favorites") from None
             raise
 
         if result.rowcount == 0: