Makefile: use golangci-lint for lint target

golint is no more, so remove it.

golangci-lint is a tool that runs multuple linters in parallel.
Default configuration includes go vet (which is being replaced),
errorcheck, and a few other linters (see golangci-lint linters).

It is assumed that users do have golangci-lint installed, or can
figure out how to do that.

Now, since golangci-lint runs govet, it makes sense to modify
the check target to call lint instead of go vet.

README is amended accordingly.

Signed-off-by: Kir Kolyshkin <[email protected]>
Acked-by: Paul Moore <[email protected]>
Signed-off-by: Tom Hromatka <[email protected]>

Author: kolyshkin

Makefile

@@ -4,7 +4,7 @@
 
 all: check-build
 
-check: vet test
+check: lint test
 
 check-build:
 	go build
@@ -16,7 +16,7 @@ fix-syntax:
 	gofmt -w .
 
 vet:
-	go vet -v
+	go vet -v ./...
 
 # Previous bugs have made the tests freeze until the timeout. Golang default
 # timeout for tests is 10 minutes, which is too long, considering current tests
@@ -28,5 +28,4 @@ test:
 	go test -v -timeout $(TEST_TIMEOUT)
 
 lint:
-	@$(if $(shell which golint),true,$(error "install golint and include it in your PATH"))
-	golint -set_exit_status
+	golangci-lint run .

README.md

@@ -45,7 +45,6 @@ you want to run the standard regression tests, you can excute the following:
 
 	# make check
 
-In order to execute the 'make lint' recipe the 'golint' tool is needed, it
-can be found at:
+In order to use it, the 'golangci-lint' tool is needed, which can be found at:
 
-* https://github.com/golang/lint
+* https://github.com/golangci/golangci-lint