Outlines partialy invisible after changing outlined entity

[thmxv]

When changing which mesh/entity should be outlined, there is something weird that happens. The outline of the first outlined mesh is fine, but for the mesh that are outlined afterward are affected by some mask/stencil created by the previous outlined mesh.

This happens with all the OutlineMode possible values.

Following are some screenshots of a mesh that is first selected/outlined. Than the selection is changed to another mesh which cause this one to be outlined. Lastly the object that was selected/outlined first is selected/outlined again. But this time the outline is barely visible (most of it is "cropped").

[komadori]

How are you enabling and disabling the outlines? It looks like the outline volume shown in the second screenshot has been disabled, but the stencil is still enabled and occludes the other outline.

[thmxv]

Hi,

For the moment the code for enabling/disabling outlines are the following. I am trying to free some time to write a minimum example that reproduce the issue, but due to family emergencies this is really a bad time for me.

pub struct Selected;

impl Component for Selected {
    const STORAGE_TYPE: StorageType = StorageType::Table;

    fn register_component_hooks(hooks: &mut ComponentHooks) {
        hooks.on_insert(|mut world, targeted_entity, _component_id| {
            let is_active = world.resource::<Context>().active_entity
                == Some(targeted_entity);
            insert_outline(is_active, world.commands().entity(targeted_entity));
            let mut ui_state = world.resource_mut::<UiState>();
            ui_state.add_to_inspector_selection(targeted_entity);
        });
        hooks.on_remove(|mut world, targeted_entity, _component_id| {
            world
                .commands()
                .entity(targeted_entity)
                .remove::<(OutlineVolume, OutlineMode)>();
            let mut ui_state = world.resource_mut::<UiState>();
            ui_state.remove_from_inspector_selection(targeted_entity);
        });
    }
}

fn insert_outline(is_active: bool, mut entity_commands: EntityCommands) {
    entity_commands.insert((
        OutlineVolume {
            visible: true,
            width: 2.0,
            colour: if is_active {
                Color::from(ORANGE_400)
            } else {
                Color::from(ORANGE_600)
            },
        },
        OutlineMode::FloodFlatDoubleSided,
        // OutlineMode::FloodFlat,
    ));
}

The Selected component is added with the use of Commands and mouse picking.

[thmxv]

I tried a few things and changing:

            world
                .commands()
                .entity(targeted_entity)
                .remove::<(OutlineVolume, OutlineMode)>();

to

            world.commands().entity(targeted_entity).remove::<(
                OutlineVolume,
                OutlineMode,
                OutlineStencil,
                ComputedOutline,
            )>();

Fixes the issue. Sorry for the inconvenience. But to discover that, I had to analyze the code and look which required components are added. Maybe a small change in the doc would help others.

EDIT: It is removing ComputedOutline that fixed the issue.

[komadori]

I've encountered a similar issue with a user on Discord, so I think this is a usability problem with the post-Bundle API since 0.9. I plan to merge #65 in the next breaking release to improve this.

[wbpaley]

I see what I believe is the same issue (an unexpectedly clipped outline when an entity's mesh is changed) but the fix above, removing of one or all Outline* & ComputedOutline, did not fix it.

Context: I want to be able to take a section of an image I've dragged into a drawing workspace (here a TextArc of Alice in Wonderland). Holding KeyS and dragging creates a 0.2 alpha white freeform polygon entity over it so you can see progress while drawing the section outline. And I'd like one of your lovely outlines around it as I draw to make it clearer. (It often goes immediately into "armed" state, so there's perceptual/cognitive continuity if it looks armed while being created; I also indicate armed with a blue outline--a very clear indication--thank you again!

I replace that polygon entity's mesh every frame to track the segment area as it's being drawn, but only see a clipped part of the outline--issue seen in the first image below. Images below: 1) the segment being drawn exhibiting the clipped blue outline (a tiny shard, with a blue outline on the orange text bg, upper right; tiny because the clip window doesn't move so I can't move far from my starting point if I want to show it); 2) that same shard--I interrupted finishing the segment so you could see the full shard outline better: it was armed when I took the previous screenshot; 3) the final intent (segment redrawn from scratch, just so you can see what I'm hoping for at every step of drawing as well as the final segment when armed); 4) segment dragged off to the right, still armed, to show the final intended result.

Don't mind waiting for the merge, but wanted to point out that the above fix didn't work here so maybe it's a deeper issue--or a different one?

Here's the snippet of code I execute on every frame:

        if data.segment_mode {
            entity_commands.remove::<(
                OutlineVolume,
                OutlineMode,
                OutlineStencil,
                ComputedOutline,
            )>();
            entity_commands.insert((
                OutlineVolume {
                    visible: true,
                    colour: Color::srgba(0., 0.4, 1., 1.),
                    width: 4.,
                },
                OutlineMode::FloodFlat,
            ));
        }

Or is there a flush()-ish thing I need to cal, or recalc(), or skip a frame, or should I do this at a different stage in Bevy's pipeline (it's currently in an observer of On<TouchEvent>), or?...

[oerli]

Not sure if I have the same issue, what I encounter is that when I changed the mesh the outline will show up just partially (or just like an initial size).
I could fix this by compute and inserting AABB:

let aabb = roadway_mesh.compute_aabb().unwrap();
commands.entity(roadway_entity).try_insert((
    Mesh3d(meshes.add(roadway_mesh)),
    aabb,
));

from bevyengine/bevy#18221