image upload: code review

Author: komplexb

lib/notify.js

@@ -148,36 +148,38 @@ async function withTelegram(note, messageSettings, login = false) {
 
   return new Promise(async(resolve, reject) => {
     try {
-      // Check for image in note content
-      const noteContent = await getNoteContents(note.url)
-      const imageInfo = extractFirstImage(noteContent.content)
+      // Handle image processing independently
+      let hasImage = false
+      try {
+        const noteContent = await getNoteContents(note.url)
+        const imageInfo = extractFirstImage(noteContent.content)
 
-      if (imageInfo?.imageUrl) {
-        console.log('Found image in note, sending photo first')
+        if (imageInfo?.imageUrl) {
+          console.log('Found image in note, sending photo first')
 
-        // Create caption with subject and alt text
-        let caption = markdownv2.bold(markdownv2.escape(msg.prefix))
-        caption += markdownv2.escape(`\n\n`)
-        caption += markdownv2.underline(markdownv2.escape(msg.title))
-        caption += markdownv2.escape(`\n\n`)
+          // Create caption with subject and alt text
+          let caption = markdownv2.bold(markdownv2.escape(msg.prefix))
+          caption += markdownv2.escape(`\n\n`)
+          caption += markdownv2.underline(markdownv2.escape(msg.title))
+          caption += markdownv2.escape(`\n\n`)
 
-        // Use alt text if available, otherwise use preview text
-        const captionText = imageInfo.altText || msg.previewText
-        caption += markdownv2.escape(captionText)
+          // Use alt text if available, otherwise use preview text
+          const captionText = imageInfo.altText || msg.previewText
+          caption += markdownv2.escape(captionText)
 
-        if(showEditLink) {
-          caption += markdownv2.escape(`\n\n`)
-          caption += markdownv2.url("Edit note", msg.webUrl)
-        }
+          if(showEditLink) {
+            caption += markdownv2.escape(`\n\n`)
+            caption += markdownv2.url("Edit note", msg.webUrl)
+          }
 
-        // Download and send image with size limits
-        try {
+          // Download and send image with size limits
           const imageBuffer = await downloadImage(imageInfo.dataFullresSrc || imageInfo.imageUrl)
           await sendPhotoToTelegram(imageBuffer, caption, channelHandle)
-        } catch (imageErr) {
-          console.warn('Failed to process image:', imageErr.message)
-          // Continue without image - note text will still be sent
+          hasImage = true
         }
+      } catch (imageErr) {
+        console.warn('Image processing failed, continuing with text message:', imageErr.message)
+        // Image processing failure doesn't affect text message flow
       }
 
       // Send note body text
@@ -198,7 +200,7 @@ async function withTelegram(note, messageSettings, login = false) {
         status: 200,
         title: msg.title,
         body: msg.previewText,
-        hasImage: !!imageInfo
+        hasImage
       })
     } catch (err) {
       console.error('Title: ', msg.title)

lib/onenote.js

@@ -313,7 +313,7 @@ function getRandomNote(notes, sectionHandle) {
     localStorage.getItem(`recent_${sectionHandle}`, true) || []
 
   if (recentNotes.includes(note.id)) {
-    getRandomNote(notes)
+    return getRandomNote(notes, sectionHandle)
   }
 
   return note
@@ -365,7 +365,7 @@ async function getImageSize(imageUrl) {
       })
       .catch(err => {
         console.error('getImageSize', err)
-        reject(new Error(err))
+        reject(err)
       })
   })
 }