-
Notifications
You must be signed in to change notification settings - Fork 14
Open
Description
A requisite for this is that we port over the test suite from[3]
replace parsedotenv.env replace env with a []string since ComposeService.Environment is a []string[1]
This will help us not incur this loop[2]
ref:
-
Lines 25 to 26 in 7fab55b
// env holds key/value pair of valid environment variable // TODO: replace env with a []string since ComposeService.Environment is a []string -
Lines 186 to 195 in 7fab55b
// TODO: replace env in parseDotEnv.go with a []string since ComposeService.Environment is a []string // that way we wont have to incur this for loop containerEnv := []string{} for k, v := range envMap { envMap[k] = v x := fmt.Sprintf("%s=%s", k, v) containerEnv = append(containerEnv, x) } containerEnv = append(containerEnv, dc.ComposeService.Environment...) fmt.Printf("\n\n containerEnv 2:%v \n", containerEnv) -
https://github.com/subosito/gotenv/blob/master/gotenv_test.go
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels