error handling is ineffective in the `git-clone` task

[kdudka]

The script of the git-clone task starts with set -eu, which makes the shell interpreter exit immediately when a command exits with a non-zero status:

build-definitions/task/git-clone/0.1/git-clone.yaml

Line 183 in 8ddc2b5

set -eu

Consequently, the bodies of all the if [ "${*_EXIT_CODE}" != "0" ] conditions are effectively dead code. For example, the git status command is never executed when a merge conflict occurs:

build-definitions/task/git-clone/0.1/git-clone.yaml

Line 281 in 8ddc2b5

git status

[ralphbean]

Ha! Good catch. :)

[Karrrthik7]

Good catch — with set -e, any command that exits non-zero (outside of conditional contexts) causes the shell to terminate immediately.
That means patterns like:

do_thing
exit_code=$?
if [ "$exit_code" != "0" ]; then
    ...
fi

will never behave as intended, because the shell exits before $? is evaluated.
If the goal is to preserve fail-fast behavior while still allowing explicit error handling in certain branches, a more robust pattern would be:

if ! do_thing; then
    ...
fi

Commands executed inside if conditions are exempt from immediate -e termination, so this keeps global safety while enabling controlled error handling.
Given that the impact here is mostly around improved error messaging (rather than correctness), and larger task refactors are being considered, it may make sense to address this comprehensively during that redesign.