fix

Signed-off-by: Robert Cerven <rcerven@redhat.com>

Author: rcerven

internal/controller/component_build_controller.go

@@ -120,9 +120,17 @@ func (r *ComponentBuildReconciler) SetupWithManager(mgr ctrl.Manager) error {
 				return true
 			},
 			UpdateFunc: func(e event.UpdateEvent) bool {
-				// Only reconcile when spec changes (Generation increments), not on status-only updates
-				// This might prevent scheduled (daily) reconcile to be triggered (but we shouldn't need it)
-				return e.ObjectOld.GetGeneration() != e.ObjectNew.GetGeneration()
+				component, ok := e.ObjectNew.(*applicationapiv1alpha1.Component)
+				if !ok {
+					return false
+				}
+
+				// For new model: only reconcile when spec changes (Generation increments), not on status-only updates
+				// For old model: always reconcile on update (old model uses annotations which don't increment Generation)
+				if isComponentUsingNewModel(component) {
+					return e.ObjectOld.GetGeneration() != e.ObjectNew.GetGeneration()
+				}
+				return true
 			},
 			DeleteFunc: func(e event.DeleteEvent) bool {
 				return false
@@ -135,6 +143,13 @@ func (r *ComponentBuildReconciler) SetupWithManager(mgr ctrl.Manager) error {
 		Complete(r)
 }
 
+// isComponentUsingNewModel checks if the component is configured to use the new model (v2).
+// Returns true if the component has the new model annotation set to v2 or if the default model is v2.
+func isComponentUsingNewModel(component *applicationapiv1alpha1.Component) bool {
+	requestedModel, requestedModelAnnotationExists := component.Annotations[ComponentModelVersionAnnotation]
+	return (requestedModelAnnotationExists && requestedModel == NewComponentModelVersion) || DefaultComponentModelVersion == NewComponentModelVersion
+}
+
 func updateMetricsTimes(componentIdForMetrics string, requestedAction string, reconcileStartTime time.Time) {
 	componentInfo, timeRecorded := bometrics.ComponentTimesForMetrics[componentIdForMetrics]
 
@@ -185,8 +200,7 @@ func (r *ComponentBuildReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 		return ctrl.Result{}, err
 	}
 
-	requestedModel, requestedModelAnnotationExists := component.Annotations[ComponentModelVersionAnnotation]
-	if (requestedModelAnnotationExists && requestedModel == NewComponentModelVersion) || DefaultComponentModelVersion == NewComponentModelVersion {
+	if isComponentUsingNewModel(&component) {
 		return r.ReconcileNewModel(ctx, req)
 	}
 

internal/controller/component_build_controller_v2.go

@@ -620,6 +620,7 @@ func (r *ComponentBuildReconciler) ReconcileNewModel(ctx context.Context, req ct
 	}
 
 	// TODO handle skip builds !!!! if it is already working in PaC
+	// TODO rework Repository naming (it has 253 limit)
 	log.Info("New model reconciliation completed successfully",
 		l.Action, l.ActionView)