Skip to content

Hangup effect #60

@mikeplavsky

Description

@mikeplavsky

I see two issues with powerslim code which can lead to hangup effect:

This code does not have any checks or error handling for the situation when port is busy:

    $ps_server = New-Object System.Net.Sockets.TcpListener($args[0])

It means that based on these specifications:

http://fitnesse.org/FitNesse.UserGuide.SliM.SlimProtocol
http://fitnesse.org/FitNesse.UserGuide.SliM.SlimProtocol.PortManagement

Fitnesse will start SlimServer and will be waiting probably forever till SlimServer sends Slim Version string

The second problem is with this code:

     $ps_fitnesse_client.Client.Poll(-1, [System.Net.Sockets.SelectMode]::SelectRead)

It does wait forever till Socket gets into the reading mode. IMHO waiting time should be restricted by time out.

Metadata

Metadata

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions