Skip to content

Commit 8cada48

Browse files
committed
chore: update Dockerfile permissions and enhance README for Docker usage
1 parent fd64a8c commit 8cada48

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ jobs:
5050
permissions:
5151
contents: read
5252
packages: write
53-
# attestations: write
5453
id-token: write
5554

5655
steps:

Dockerfile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,10 @@ RUN apt-get update && \
5252
rm -rf /var/cache/apt/*
5353

5454
# Copy only necessary files from builder
55-
COPY --from=builder --chown=python:python /python /python
56-
COPY --from=builder --chown=app:app /app /app
55+
COPY --from=builder /python /python
56+
COPY --from=builder /app /app
57+
# Set proper permissions
58+
RUN chmod -R 755 /python /app
5759

5860
ENV PATH="/app/.venv/bin:$PATH" \
5961
DISPLAY=:0 \

README.md

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -154,18 +154,29 @@ To develop and test the package locally:
154154

155155
## Docker
156156

157+
Using Docker provides a consistent and isolated environment for running the server.
158+
157159
```bash
158-
# Run with default VNC password
160+
# Build the Docker image
159161
docker build -t browser-use-mcp-server .
162+
163+
# Run the container with the default VNC password ("browser-use")
164+
# --rm ensures the container is automatically removed when it stops
165+
# -p 8000:8000 maps the server port
166+
# -p 5900:5900 maps the VNC port
160167
docker run --rm -p8000:8000 -p5900:5900 browser-use-mcp-server
161168

162-
# Use custom VNC password
163-
echo "your-password" > vnc_password.txt
169+
# Run with a custom VNC password read from a file
170+
# Create a file (e.g., vnc_password.txt) containing only your desired password
171+
echo "your-secure-password" > vnc_password.txt
172+
# Mount the password file as a secret inside the container
164173
docker run --rm -p8000:8000 -p5900:5900 \
165-
-v $(pwd)/vnc_password.txt:/run/secrets/vnc_password \
174+
-v $(pwd)/vnc_password.txt:/run/secrets/vnc_password:ro \
166175
browser-use-mcp-server
167176
```
168177

178+
*Note: The `:ro` flag in the volume mount (`-v`) makes the password file read-only inside the container for added security.*
179+
169180
### VNC Viewer
170181

171182
```bash
@@ -175,7 +186,7 @@ cd noVNC
175186
./utils/novnc_proxy --vnc localhost:5900
176187
```
177188

178-
Default password: `browser-use`
189+
Default password: `browser-use` (unless overridden using the custom password method)
179190

180191
<div align="center">
181192
<img width="428" alt="VNC Screenshot" src="https://github.com/user-attachments/assets/45bc5bee-418d-4182-94f5-db84b4fc0b3a" />

0 commit comments

Comments
 (0)