Batch transfer fixes (#274)

* Fix typo in account.id

* Map transfers and bookings for list endpoint response

* 1.0.183

Author: p-janik

npm-shrinkwrap.json

@@ -1,6 +1,6 @@
 {
   "name": "@kontist/mock-solaris",
-  "version": "1.0.182",
+  "version": "1.0.183",
   "description": "Mock Service for Solaris API",
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",

package.json

@@ -160,9 +160,11 @@ export const confirmBatchTransfer = async (person, changeRequestId) => {
 
   await savePerson(person);
 
+  const account = person.accounts?.length ? person.accounts[0] : person.account;
+
   return {
     id,
-    account_id: person.accounts[0].id,
+    account_id: account.id,
     status: "ACCEPTED",
     transfer_type: transferType,
     description,
@@ -181,6 +183,31 @@ export const confirmBatchTransfer = async (person, changeRequestId) => {
   };
 };
 
+const mapBatchTransferTransaction = (item, accountId) => {
+  const statusMap = {
+    accepted: "BOOKED",
+    rejected: "FAILED",
+  };
+
+  return {
+    id: item.id,
+    account_id: accountId,
+    status: statusMap[item.status] || item.status,
+    type: item.booking_type || item.type,
+    creditor_iban: item.recipient_iban || item.creditor_iban,
+    creditor_name: item.recipient_name || item.creditor_name,
+    amount: item.amount,
+    description: item.description,
+    end_to_end_id: item.end_to_end_id,
+    initiator_reference: item.reference || item.initiator_reference,
+    failure_reason: null,
+    batch_id: item.batch_id,
+    schedule_id: null,
+    created_at: item.created_at || item.booking_date,
+    updated_at: item.updated_at || item.valuta_date,
+  };
+};
+
 export const listBatchTransferTransactions = async (req, res) => {
   const { account_id: accountId, batch_transfer_id: batchTransferId } =
     req.params;
@@ -193,5 +220,10 @@ export const listBatchTransferTransactions = async (req, res) => {
     (transaction) => transaction.batch_id === batchTransferId
   );
 
-  res.status(HttpStatusCodes.OK).send([...bookings, ...transfers]);
+  const allTransactions = [...bookings, ...transfers];
+  const mappedTransactions = allTransactions.map((item) =>
+    mapBatchTransferTransaction(item, accountId)
+  );
+
+  res.status(HttpStatusCodes.OK).send(mappedTransactions);
 };