Merge pull request #269 from kontist/krp-2205-fix-issue-on-update-instant-limits

KRP-2205 Fix issue on updateInstantLimits

Author: sinahashemy

npm-shrinkwrap.json

@@ -1,6 +1,6 @@
 {
   "name": "@kontist/mock-solaris",
-  "version": "1.0.177",
+  "version": "1.0.178",
   "description": "Mock Service for Solaris API",
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",

package.json

@@ -933,7 +933,7 @@ router.get(
   "/accounts/:accountId/sepa_instant_limits",
   safeRequestHandler(instantCreditTransferAPI.getInstantLimits)
 );
-router.post(
+router.patch(
   "/accounts/:accountId/sepa_instant_limits",
   safeRequestHandler(instantCreditTransferAPI.updateInstantLimits)
 );

src/app.ts

@@ -244,16 +244,19 @@ export const updateInstantLimits = async (req, res) => {
     throw new Error("Account not found");
   }
 
-  if (!daily_limit && !per_transaction_limit) {
+  if (daily_limit === undefined && per_transaction_limit === undefined) {
     throw new Error("Daily limit or per transaction limit are required");
   }
 
+  if (per_transaction_limit === null) {
+    throw new Error("Per transaction limit cannot be null");
+  }
+
   return res.send({
-    daily_limit: daily_limit || {
-      value: 1000000,
-      unit: "cents",
-      currency: "EUR",
-    },
+    daily_limit:
+      daily_limit === undefined
+        ? { value: 1000000, unit: "cents", currency: "EUR" }
+        : daily_limit,
     daily_used: { value: 350000, unit: "cents", currency: "EUR" },
     daily_remaining: { value: 650000, unit: "cents", currency: "EUR" },
     per_transaction_limit: per_transaction_limit || {