👻 New binding tests. (#997)

Created new test/binding tests using cleaner approach.  Uses:
- gomega
- t.Cleanup()
- cmp.Eq()

Eliminates samples. I'm not convinced the variation in samples was
extensive enough to warrant the added complexity. Further, I doubt the
samples are that usable by other projects. The approach here is to
round-trip the most complete version of each resource.

Adds a number of missing bindings.
Adds a number of missing tests.

Adds sorting to the test/cmp.
Adds internal/k8s/seed (configMap).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Expanded binding APIs: analysis, reports, imports, archetype
assessments, configmap access, file listing, task/taskgroup
enhancements, task attachments, bulk app deletion, and stakeholder
updates.

* **Bug Fixes**
* Manifest queries now eagerly load associations; application fact
deletion scope tightened.

* **Tests**
* Large set of new integration and unit tests covering binding APIs and
resources.

* **Documentation**
  * Added binding and binding-test guidelines (CLAUDE.md).

* **Refactor**
  * TaskPolicy schema simplified (preempt fields removed).
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jeff Ortel <jortel@redhat.com>

Author: jortel

.github/workflows/main.yml

@@ -45,6 +45,25 @@ jobs:
           go-version: '1.21'
       - run: make test
 
+  test-binding:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          repository: konveyor/tackle2-seed
+      - run: |
+          mkdir -p /tmp/seed
+          cp -r resources/* /tmp/seed
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v3
+        with:
+          go-version: '1.21'
+      - run: |
+          make vet
+          DISCONNECTED=1 make run &
+          sleep 15  # probably a dirty solution
+          HUB_BASE_URL=http://localhost:8080 make test-binding
+
   test-api:
     needs:
     - fmt

.github/workflows/test-nightly.yml

@@ -14,6 +14,25 @@ jobs:
           go-version: '1.21'
       - run: make test
 
+  test-binding:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          repository: konveyor/tackle2-seed
+      - run: |
+          mkdir -p /tmp/seed
+          cp -r resources/* /tmp/seed
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v3
+        with:
+          go-version: '1.21'
+      - run: |
+          make vet
+          DISCONNECTED=1 make run &
+          sleep 15  # probably a dirty solution
+          HUB_BASE_URL=http://localhost:8080 make test-binding
+
   test-api:
     runs-on: ubuntu-latest
     steps:
@@ -26,4 +45,3 @@ jobs:
           DISCONNECTED=1 make run &
           sleep 15  # probably a dirty solution
           HUB_BASE_URL=http://localhost:8080 make test-api
-          HUB_BASE_URL=http://localhost:8080 make test-api  # Intentionaly run 2x to catch data left in Hub DB.

Makefile

@@ -135,6 +135,10 @@ test-api:
 	for pkg in $$(go list ./test/api/...); do \
 	  HUB_BASE_URL="$(HUB_BASE_URL)" go test -count=1 -v -failfast "$$pkg" || exit 1; \
 	done
+test-binding:
+	for pkg in $$(go list ./test/binding/...); do \
+	  HUB_BASE_URL="$(HUB_BASE_URL)" go test -count=1 -v -failfast "$$pkg" || exit 1; \
+	done
 
 # Run Hub test suite.
 test-all: test-unit test-api

docs/docs.go

@@ -8549,12 +8549,6 @@ const docTemplate = `{
                 "isolated": {
                     "type": "boolean"
                 },
-                "preemptEnabled": {
-                    "type": "boolean"
-                },
-                "preemptExempt": {
-                    "type": "boolean"
-                }
             }
         },
         "github_com_konveyor_tackle2-hub_api.TaskQueue": {

hack/cmd/addon/main.go

@@ -18,6 +18,7 @@ import (
 
 	hub "github.com/konveyor/tackle2-hub/shared/addon"
 	"github.com/konveyor/tackle2-hub/shared/api"
+	bucketapi "github.com/konveyor/tackle2-hub/shared/binding/bucket"
 	"github.com/konveyor/tackle2-hub/shared/nas"
 	"k8s.io/apimachinery/pkg/util/rand"
 )
@@ -154,7 +155,7 @@ func listDir(d *Data, application *api.Application, paths []string) (err error)
 	//
 	// Upload list directory.
 	addon.Activity("[BUCKET] uploading %s => bucket/%s.", output, BucketDir)
-	bucket := addon.Application.Bucket(application.ID)
+	bucket := addon.Application.Select(application.ID).Bucket
 	err = bucket.Put(output, BucketDir)
 	if err != nil {
 		return
@@ -178,7 +179,7 @@ func listDir(d *Data, application *api.Application, paths []string) (err error)
 }
 
 // playWithBucket
-func playWithBucket(bucket hub.BucketContent) (err error) {
+func playWithBucket(bucket bucketapi.Content) (err error) {
 	tmpDir := tmpDir()
 	defer func() {
 		_ = nas.RmDir(tmpDir)

internal/api/application.go

@@ -1061,8 +1061,7 @@ func (h ApplicationHandler) FactReplace(ctx *gin.Context, key FactKey) {
 		_ = ctx.Error(err)
 		return
 	}
-
-	// remove all the existing Facts for that source and app id.
+	// Delete all the existing facts with that source and application id.
 	db := h.DB(ctx)
 	db = db.Where("ApplicationID", id)
 	db = db.Where("Source", key.Source())
@@ -1071,16 +1070,14 @@ func (h ApplicationHandler) FactReplace(ctx *gin.Context, key FactKey) {
 		_ = ctx.Error(err)
 		return
 	}
-
-	// create new Facts
+	// Create new facts.
 	if len(facts) > 0 {
 		newFacts := []model.Fact{}
 		for k, v := range facts {
-			value, _ := json.Marshal(v)
 			newFacts = append(newFacts, model.Fact{
 				ApplicationID: id,
 				Key:           FactKey(k).Name(),
-				Value:         value,
+				Value:         v,
 				Source:        key.Source(),
 			})
 		}

internal/api/manifest.go

@@ -12,6 +12,7 @@ import (
 	"github.com/konveyor/tackle2-hub/internal/model"
 	"github.com/konveyor/tackle2-hub/internal/secret"
 	"github.com/konveyor/tackle2-hub/shared/api"
+	"gorm.io/gorm/clause"
 )
 
 const (
@@ -56,6 +57,7 @@ func (h ManifestHandler) Get(ctx *gin.Context) {
 	id := h.pk(ctx)
 	m := &model.Manifest{}
 	db := h.DB(ctx)
+	db = db.Preload(clause.Associations)
 	err := db.First(m, id).Error
 	if err != nil {
 		_ = ctx.Error(err)
@@ -98,6 +100,7 @@ func (h ManifestHandler) List(ctx *gin.Context) {
 	// Fetch.
 	var list []model.Manifest
 	db := h.DB(ctx)
+	db = db.Preload(clause.Associations)
 	db = filter.Where(db)
 	err = db.Find(&list).Error
 	if err != nil {

internal/api/resource/manifest.go

@@ -13,7 +13,7 @@ func (r *Manifest) With(m *model.Manifest) {
 	baseWith(&r.Resource, &m.Model)
 	r.Content = m.Content
 	r.Secret = m.Secret
-	r.Application = Ref{ID: m.ApplicationID, Name: ""}
+	r.Application = Ref{ID: m.ApplicationID, Name: m.Application.Name}
 }
 
 // Model builds a model.