Skip to content

feat(input): always-on password-toggle (#DS-4288) #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NikGurev merged 4 commits into from
Jan 23, 2026
Merged

feat(input): always-on password-toggle (#DS-4288) #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97e5a7b
feat(input): always-on password-toggle (#DS-4288)
NikGurev Jan 21, 2026
eba1c75
test: updated e2e snapshots
NikGurev Jan 21, 2026
9ab3684
chore: updated test
NikGurev Jan 22, 2026
3abe7cc
chore: revert tabs example
NikGurev Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components-experimental/form-field/password-toggle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export class KbqPasswordToggle {

/** Whether to display the password toggle. */
get visible(): boolean {
return !this.formField?.disabled && !!this.control?.ngControl?.value;
return !this.formField?.disabled;
}

/** Toggles the password visibility. */
Expand Down
6 changes: 3 additions & 3 deletions packages/components/form-field/__snapshots__/form-field.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,9 @@ DebugElement {
exports[`KbqFormField should hide KbqPasswordToggle initially 1`] = `
DebugElement {
"nativeNode": <kbq-password-toggle
aria-hidden="true"
class="kbq-password-toggle kbq kbq-icon-button kbq-contrast-fade kbq-eye_16 cdk-visually-hidden"
style="visibility: hidden;"
aria-hidden="false"
class="kbq-password-toggle kbq kbq-icon-button kbq-contrast-fade kbq-eye_16"
style="visibility: visible;"
tabindex="0"
/>,
}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/form-field/password-toggle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export class KbqPasswordToggle extends KbqTooltipTrigger implements AfterViewIni
* @docs-private
*/
get visibility(): 'hidden' | 'visible' {
return this.control.disabled || this.control.empty ? 'hidden' : 'visible';
return this.control.disabled ? 'hidden' : 'visible';
}

constructor() {
Expand Down
Binary file modified packages/components/input/__screenshots__/02-dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/components/input/__screenshots__/02-light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.