Skip to content

Commit 1d9d32b

Browse files
committed
Fix Deployment labels / selectorLabels | generic 1.8.0
1 parent 917f349 commit 1d9d32b

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

charts/generic/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
apiVersion: v2
22
name: generic
33
description: Generic Chart
4-
version: 1.7.0
4+
version: 1.8.0

charts/generic/templates/_helpers.tpl

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,26 @@ Common labels
3636
*/}}
3737
{{- define "generic.labels" -}}
3838
helm.sh/chart: {{ include "generic.chart" . }}
39-
{{ include "generic.selectorLabels" . }}
39+
app.kubernetes.io/name: {{ include "generic.name" . }}
40+
app.kubernetes.io/instance: {{ .Release.Name }}
4041
{{- if .Chart.AppVersion }}
4142
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
4243
{{- end }}
4344
app.kubernetes.io/managed-by: {{ .Release.Service }}
4445
{{- end }}
4546

47+
{{- define "generic.deploymentLabels" -}}
48+
{{- include "generic.labels" . }}
49+
app.kubernetes.io/deployment: {{ include "generic.name" . }}
50+
{{- end }}
51+
4652
{{/*
4753
Selector labels
4854
*/}}
4955
{{- define "generic.selectorLabels" -}}
5056
app.kubernetes.io/name: {{ include "generic.name" . }}
5157
app.kubernetes.io/instance: {{ .Release.Name }}
58+
app.kubernetes.io/deployment: {{ include "generic.name" . }}
5259
{{- end }}
5360

5461
{{/*

charts/generic/templates/deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ apiVersion: apps/v1
33
kind: Deployment
44
metadata:
55
name: {{ $fullName }}
6-
labels: {{ include "generic.labels" $ | nindent 4 }}
6+
labels: {{ include "generic.deploymentLabels" $ | nindent 4 }}
77
{{- with .annotations }}
88
annotations: {{ toYaml . | nindent 4 }}
99
{{- end }}

0 commit comments

Comments
 (0)