Skip to content

Commit 699c57a

Browse files
authored
Merge pull request #10 from kool-dev/security-check
fix php security check command - updated on image
2 parents 3ec066b + 19829dd commit 699c57a

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

laravel/gitlab/index.html

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,12 @@ <h3>GitLab CI/CD configuration for a Laravel application running with Kool.dev</
143143

144144
<div style="margin: 1em 5em; padding: 1em;" class="bg-dark">
145145
<pre class="text-light">
146+
# make sure to add phpqa since it will be used by all other commands
147+
# the image used here is pinned to a known working version with the
148+
# commands configured in this sample kool.yml
146149
phpqa: kool docker jakzal/phpqa:php7.4-alpine
147-
# helpful to sync up service dependencies
150+
151+
# helpful to sync up service dependencies - used when we need to wait for services to startup
148152
wait-services: kool exec app dockerize -wait tcp://database:3306 -wait tcp://cache:6379 -timeout 30s
149153

150154
# quality assurance tools
@@ -153,7 +157,7 @@ <h3>GitLab CI/CD configuration for a Laravel application running with Kool.dev</
153157
phpcpd: kool run phpqa phpcpd --fuzzy app
154158
phpmd: kool run phpqa phpmd app text phpmd/codesize.xml,phpmd/controversial.xml,phpmd/design.xml,phpmd/naming.xml,unusedcode,phpmd/cleancode.xml
155159
phpmnd: kool run phpqa phpmnd app --ignore-funcs=round,sleep,abort,strpad,number_format --exclude=tests --progress --extensions=default_parameter,-return,argument
156-
php-security-checker: kool run phpqa security-checker security:check composer.lock
160+
php-security-checker: kool run phpqa local-php-security-checker
157161
phpunit: kool exec app ./vendor/bin/phpunit
158162
start:chrome: kool docker -- --name="chromedriver" --network=$KOOL_GLOBAL_NETWORK -d --shm-size=256M fireworkweb/chromedriver:latest
159163
stop:chrome: docker stop chromedriver

0 commit comments

Comments
 (0)