Skip to content

Commit 9b31f94

Browse files
authored
Merge pull request #508 from kool-dev/typo-expose
fix typo + upgrade guide fixes
2 parents 5b3b769 + 8a39d01 commit 9b31f94

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

docs/25-Upgrade-Guide/0-Upgrading-Kool.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,12 @@ Version 3.x introduces two significant changes:
1919
- The YAML syntax for `services.<service>.build` in the `kool.cloud.yml` configuration file must now align with the official [Docker Compose reference for the `service.<service>.build`](https://docs.docker.com/compose/compose-file/compose-file-v3/#build) entry.
2020
- Image building now occurs in your local environment—specifically, on the host where you execute `kool cloud deploy`. Therefore, ensure that the environment from which you run this command has a properly configured Docker-image build engine (that means Kool to be able to run `docker build` command).
2121

22+
### Deployment network configuration: `services.<service>.public` and `services.<service>.expose`
23+
24+
The old `services.<service>.port` should now be `services.<service>.expose` - which aligns the format to Docker Compose native configuration.
25+
26+
The `services.<service>.public` entry is now preferred to be a *boolean* value - simply set to `true` to indicate that the service should be made publicly available upon deployment.
27+
2228
### Github Action `kool-dev/action`
2329

2430
There's a new version of our official installation GH action `kool-dev/action@v3` - that will always install the latest v3 series release.

services/cloud/deploy_validator.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,11 @@ func ValidateConfig(deployConfig *DeployConfig) (err error) {
125125
}
126126
}
127127

128-
// validates only one service can be public, and it must define a port
128+
// validates only one service can be public, and it must define a port to be exposed
129129
if config.Public != nil {
130-
// being public, it must define the `port` entry as well
130+
// being public, it must define the `expose` entry as well
131131
if config.Expose == nil {
132-
err = fmt.Errorf("service (%s) is public, but it does not define the `export` entry", service)
132+
err = fmt.Errorf("service (%s) is public, but it does not define the `expose` entry", service)
133133
return
134134
}
135135
}

0 commit comments

Comments
 (0)