misc

Author: koppi

src/arpeggiator.c

@@ -307,14 +307,103 @@ int arpeggiator_generate_chord(const Arpeggiator *arp, int root_note, int *chord
 
     // Apply voicing/inversion if specified
     if (arp->voicing > 0 && note_count > 1) {
-        int inversion = arp->voicing % note_count;
-        for (int i = 0; i < inversion; ++i) {
-            int bass_note = chord_notes[0];
-            // Move bass note up one octave
-            for (int j = 0; j < note_count - 1; ++j) {
-                chord_notes[j] = chord_notes[j + 1];
+        int voicing_level = arp->voicing;
+        
+        // Voicing levels 1-8: Basic inversions (rotate notes up by octaves)
+        if (voicing_level <= 8) {
+            int num_inversions = voicing_level % note_count;
+            for (int i = 0; i < num_inversions; ++i) {
+                int bass_note = chord_notes[0];
+                // Move bass note up one octave
+                for (int j = 0; j < note_count - 1; ++j) {
+                    chord_notes[j] = chord_notes[j + 1];
+                }
+                chord_notes[note_count - 1] = bass_note + 12;
+            }
+        }
+        // Voicing levels 9-12: Drop voicings (drop 2, drop 3, etc.)
+        else if (voicing_level <= 12 && note_count >= 3) {
+            int drop_type = voicing_level - 8; // 1=drop2, 2=drop3, 3=drop2&4, 4=drop2&3
+            int temp_notes[8];
+            memcpy(temp_notes, chord_notes, sizeof(int) * note_count);
+            
+            switch (drop_type) {
+                case 1: // Drop 2
+                    if (note_count >= 2) {
+                        chord_notes[0] = temp_notes[0];
+                        chord_notes[1] = temp_notes[1] - 12; // Second down octave
+                        for (int i = 2; i < note_count; ++i) {
+                            chord_notes[i] = temp_notes[i];
+                        }
+                    }
+                    break;
+                case 2: // Drop 3
+                    if (note_count >= 3) {
+                        chord_notes[0] = temp_notes[0];
+                        chord_notes[1] = temp_notes[1];
+                        chord_notes[2] = temp_notes[2] - 12; // Third down octave
+                        for (int i = 3; i < note_count; ++i) {
+                            chord_notes[i] = temp_notes[i];
+                        }
+                    }
+                    break;
+                case 3: // Drop 2&4
+                    if (note_count >= 4) {
+                        chord_notes[0] = temp_notes[0];
+                        chord_notes[1] = temp_notes[1] - 12; // Second down octave
+                        chord_notes[2] = temp_notes[2];
+                        chord_notes[3] = temp_notes[3] - 12; // Fourth down octave
+                        for (int i = 4; i < note_count; ++i) {
+                            chord_notes[i] = temp_notes[i];
+                        }
+                    }
+                    break;
+                case 4: // Drop 2&3
+                    if (note_count >= 3) {
+                        chord_notes[0] = temp_notes[0];
+                        chord_notes[1] = temp_notes[1] - 12; // Second down octave
+                        chord_notes[2] = temp_notes[2] - 12; // Third down octave
+                        for (int i = 3; i < note_count; ++i) {
+                            chord_notes[i] = temp_notes[i];
+                        }
+                    }
+                    break;
+            }
+        }
+        // Voicing levels 13-16: Open/Spread voicings
+        else {
+            int spread_type = voicing_level - 12; // 1=open harmony, 2=wide spread, 3=clustered, 4=alternating octaves
+            int temp_notes[8];
+            memcpy(temp_notes, chord_notes, sizeof(int) * note_count);
+            
+            switch (spread_type) {
+                case 1: // Open harmony (spread notes across larger range)
+                    for (int i = 0; i < note_count; ++i) {
+                        chord_notes[i] = temp_notes[i] + (i * 5); // Spread by perfect 4ths
+                    }
+                    break;
+                case 2: // Wide spread (alternating octaves)
+                    for (int i = 0; i < note_count; ++i) {
+                        chord_notes[i] = temp_notes[i] + ((i % 2) * 12); // Every other note up octave
+                    }
+                    break;
+                case 3: // Clustered voicing (close harmony)
+                    // Keep notes close together in one octave range
+                    for (int i = 1; i < note_count; ++i) {
+                        while (chord_notes[i] - chord_notes[i-1] > 12) {
+                            chord_notes[i] -= 12;
+                        }
+                        while (chord_notes[i] - chord_notes[i-1] < 0) {
+                            chord_notes[i] += 12;
+                        }
+                    }
+                    break;
+                case 4: // Alternating octaves (root position with octave displacement)
+                    for (int i = 0; i < note_count; ++i) {
+                        chord_notes[i] = temp_notes[i] + ((i / 2) * 12); // Groups of 2 in same octave
+                    }
+                    break;
             }
-            chord_notes[note_count - 1] = bass_note + 12;
         }
     }
 

src/gui.cpp

@@ -627,6 +627,18 @@ void gui_draw(Synth *synth, SDL_Window *window, SDL_GLContext gl_context,
 
         // Voicing
         ImGui::SliderInt("Voicing", &synth->arp.voicing, 0, 16, "%d");
+        if (ImGui::IsItemHovered()) {
+            const char* voicing_descriptions[] = {
+                "Root Position",
+                "1st Inversion", "2nd Inversion", "3rd Inversion", "4th Inversion",
+                "5th Inversion", "6th Inversion", "7th Inversion", "8th Inversion",
+                "Drop 2", "Drop 3", "Drop 2&4", "Drop 2&3",
+                "Open Harmony", "Wide Spread", "Clustered", "Alternating Octaves"
+            };
+            if (synth->arp.voicing >= 0 && synth->arp.voicing <= 16) {
+                ImGui::SetTooltip("%s", voicing_descriptions[synth->arp.voicing]);
+            }
+        }
 
         ImGui::Separator();
         ImGui::Text("Presets:");