deprecations

kornrunner · kornrunner · commit e455f9d39276 · 2025-11-15T01:40:56.000+01:00
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -27,7 +27,7 @@ jobs:
       - run: php -m
       - run: composer -V
       - run: composer install --no-progress
-      - run: php vendor/bin/phpunit
+      - run: php vendor/bin/phpunit --no-coverage
 
   windows:
     name: Test on Windows
@@ -59,7 +59,7 @@ jobs:
       - run: php -m
       - run: composer -V
       - run: composer install --no-progress
-      - run: php vendor/bin/phpunit
+      - run: php vendor/bin/phpunit --no-coverage
 
   code_coverage:
     name: Code Coverage
diff --git a/.gitignore b/.gitignore
@@ -8,4 +8,5 @@ composer.lock
 nbproject/
 build/
 .phpunit.result.cache
+.phpunit.cache/
 infection.log
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,9 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="vendor/autoload.php" backupGlobals="false" backupStaticAttributes="false" colors="true" verbose="true" convertErrorsToExceptions="true" convertNoticesToExceptions="true" convertWarningsToExceptions="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="vendor/autoload.php" backupGlobals="false" colors="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.5/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false">
   <coverage>
-    <include>
-      <directory suffix=".php">src</directory>
-    </include>
     <report>
       <clover outputFile="build/logs/clover.xml"/>
       <html outputDirectory="build/coverage"/>
@@ -18,4 +15,9 @@
   <logging>
     <junit outputFile="build/report.junit.xml"/>
   </logging>
+  <source>
+    <include>
+      <directory suffix=".php">src</directory>
+    </include>
+  </source>
 </phpunit>
diff --git a/test/AddressTest.php b/test/AddressTest.php
@@ -3,6 +3,7 @@
 namespace kornrunner\Ethereum;
 
 use InvalidArgumentException;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 
 class AddressTest extends TestCase {
@@ -22,9 +23,7 @@ public function testCreateFromPrivateKey(): void {
         $this->assertSame('677a637ec8f0bb2c8d33c6ace08054e521bff4b5', $address->get());
         $this->assertSame('5f65c9c32a4e38393b79ccf94913c1e5dbe7071d4264aad290d936c4bb2a7c0e3a71ebc855aaadd38f477320d54cd88e5133bfcf97bbf037252db4cd824ab902', $address->getPublicKey());
     }
-    /**
-     * @dataProvider privateKeyPading
-     */
+    #[DataProvider('privateKeyPading')]
     public function testPrivateKeyPadding($key, $public): void {
         $address = new Address($key);
         $this->assertSame($public, $address->get());
